No reason not to.

CommentFileSizeAuthor
#8 hide-create-variants-button-when-variants-field-is-active-on-product-3009358-8.patch788 bytesmichaelsoetaert

Comments

bojanz created an issue. See original summary.

bojanz credited John Pitcairn.

bojanz’s picture

bojanz commented

  • bojanz committed 39a111b on 8.x-2.x 
    Issue #3009358 by bojanz, John Pitcairn: Hide the "Save and add...
  • bojanz committed c10bc8b on 8.x-2.x
    Issue #3009358 by John Pitcairn: Hide the "Save and add variations"...
bojanz’s picture

bojanz commented
Status: Active » Fixed

A squash went wrong here. But oh well. First commit is the original approach, the second one is the cleanup I made.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

lunk rat’s picture

lunk rat commented

I still see "Save and add variations" button, even when my product type Manage Form display for the variations field is set to the IEF simlple, IEF complex, or Product Information widgets.

From a UX standpoint the "Save and add variations" should not show ever, unless the Variations field is set to [Disabled] in Manage form display. Because if you can create variations from the product form—no matter what widget is used—you might see that "Save and add variations" and think "well I'm adding variations on this form, so I want to save the variations I created here in front of me, yes!"

Please at least look into why the button still shows with the IEF widget, but consider disabling that button for all widgets. I argue that it only needs to show when the field is disabled in Manage form display.

michaelsoetaert’s picture

michaelsoetaert
Primary language Dutch
Location Belgium 🇧🇪
commented
StatusFileSize
new hide-create-variants-button-when-variants-field-is-active-on-product-3009358-8.patch788 bytes
loze’s picture

loze commented

I still see this this button as well. the patch in #8 fixed it.