If a role is deleted and then an admin role is selected ksort causes the incorrect array value to be set in adminrole_adminrole. Instead asort should be used as this maintains the assocaited key order. I'd role a patch but.. as this is basically a one letter change on line 67 it doesn't seem worth it ;-)

CommentFileSizeAuthor
#2 admin role.patch857 bytesmarcingy
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

marcingy’s picture

marcingy CreditAttribution: marcingy commented
Status: Active » Needs review
marcingy’s picture

marcingy CreditAttribution: marcingy commented
FileSize
admin role.patch857 bytes

On further investigation more changes are required so here is a patch

marcingy’s picture

marcingy CreditAttribution: marcingy commented
Title: ksort cause incorrect results » ksort cause incorrect results when role has been deleted
Bevan’s picture

Bevan CreditAttribution: Bevan commented
Status: Needs review » Postponed (maintainer needs more info)

I can't reproduce this bug. Please retest with drupal 6 dev and provide more detailed instructions to reproduce

Bevan’s picture

Bevan CreditAttribution: Bevan commented
Title: ksort cause incorrect results when role has been deleted » Use asort instead of ksort
Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented
Status: Postponed (maintainer needs more info) » Closed (works as designed)

ksort maintains key => value associations so I don't see a bug here.