Users w/o access to content should still have configurable access to the content URL

That is an initial review. However, I am not 100% familiar with the link base and the usage in Drupal (like the Url class) so it would be nice to have more than one reviews on that.

1. +++ b/core/modules/views/src/Plugin/views/field/LinkBase.php
   @@ -95,6 +96,12 @@ public function buildOptionsForm(&$form, FormStateInterface $form_state) {
   +      '#description' => $this->t('When on, the link will be displayed regardless if the user is allowed to access the link destination page.'),
   

   "When checked" is more appropriate here.

2. +++ b/core/modules/views/src/Plugin/views/field/LinkBase.php
   @@ -122,6 +129,12 @@ public function query() {
   +    if ($this->options['bypass_access_check']) {
   +      return [
   +        '#markup' => $this->renderLink($row),
   +      ];
   +    }
   +
   

   This can be added in the access check below as

   $access = $this->options['bypass_access_check'] ? AccessResult::allowed() : $this->checkUrlAccess($row);

working on it

Patch works fine for me. Setting to rtbc.

Changing this to needs work as the tests failed.

I'm not entirely sure about the rationale stated in the issue summary. Drupal goes out of its way very often to not render links to things a re user does not have access to. Are we sure this functionality is core-worthy? It'd be great to see a views maintainer or product manager chime in on this issue.

+++ b/core/modules/views/views.post_update.php
@@ -366,3 +367,32 @@ function views_post_update_table_display_cache_max_age(&$sandbox = NULL) {
+function views_post_update_bypass_access_check() {
+  /** @var \Drupal\views\Plugin\ViewsHandlerManager $field_manager */
+  $field_manager = \Drupal::service('plugin.manager.views.field');
+
+  /** @var \Drupal\views\ViewEntityInterface $view */
+  foreach (View::loadMultiple() as $view) {
+    $displays = $view->get('display');
+    $save = FALSE;
+    foreach ($displays as $display_name => &$display) {
+      if (isset($display['display_options']['fields'])) {
+        foreach ($display['display_options']['fields'] as $field_name => &$field) {
+          $field_instance = $field_manager->getHandler($field);
+          // Consider all plugins extending LinkBase.
+          if ($field_instance instanceof LinkBase) {
+            $field['bypass_access_check'] = FALSE;
+            $save = TRUE;
+          }
+        }
+      }
+    }
+    if ($save) {
+      $view->set('display', $displays)->save();
+    }
+  }
+}

Use ConfigEntityUpdateer to do this in a batch. See views_post_update_table_display_cache_max_age() for an example.

@claudiu.cristea yeah but that is a bug.

Yeah this feels very edge case-y to me. Anything that adds something called 'bypass_access_check' gives me pause.

Is there any reason that when you need this you can't just extend whatever plugin you need to override and hook_field_views_data_alter/hook_views_data_alter to use your plugin for the appropriate fields? I understand that this can be hassle if you want this for all plugins extending LinkBase, but realistically we are only talking about EntityLink right (RevisionLinkRevert anybody?).

Well that's my 2 cents any way.

Rerolled against 9.4.x and opened a MR for it.

Here is also a patch rolled against the current stable 9.3.x. branch.