The link url in views must be translatable

Sounds like a bug if you can't translate. Patch applies cleanly to 9.1.

The patch is straightforward but this needs tests and manual testing. Back to needs work for tests.

Hi @Kristen Pol @larowlan
I've added the test cases for verification.
Currently, I've implemented functional test cases and on views translation page, I am checking if fields exist or not.

Any thoughts if we can achieve this using Kernel tests? I didn't found any specific schema tests in config_translation module.

@mohit_aghera Thanks for the tests :) I didn't find any kernel tests for similar things, but maybe I missed them. I see tests for link_url in:

./core/modules/views_ui/tests/src/Functional/DisplayTest.php
./core/modules/views/tests/src/Functional/Plugin/DisplayTest.php

and for Views config_translation in:

./core/modules/views_ui/tests/src/Functional/TranslatedViewTest.php

Maybe it makes sense to move your tests to TranslatedViewTest?

Sure, let me refactor the tests today and move to appropriate places.

Refactoring test cases.
Please ignore this comment due to incorrect diff with 9.2.x HEAD

Re-uploading the patch.
By mistake, I took incorrect diff with older 9.2.x HEAD

Thanks for moving the test code. This still needs manual testing. Let me see if anyone on the bugsmash team has time to do that.

Looking good already. Just nits.

Can we not add the new test assertions to \Drupal\Tests\views_ui\Functional\TranslatedViewTest::testTranslatedStrings directly and use the views.view.files view like that does? Seems like a bit of a waste to do a new test and add a whole new view.

@Lendude,
I've updated patch and removed the custom view.
However, the process was little tricky and I had to add the "block" in files view.
Because we don't get "More link" option with custom link on general views.

I had performed other changes as well.

@mohit_aghera great cleanup, makes it much easier to follow.

Manually tested this and the translation does indeed show up.

Updated the IS a bit, and added that we don't normally have update hooks for these.

Verified and tested patch #21.
Patch applied successfully and looks good to me.

Testing Steps:
# Goto: Extend -> Enable Content translation and configuration translation
# Add any multiple languages -> admin/config/regional/language
# Goto: admin/structure/views/view/content
# Click on +Add link to add one block
# Click on "Content: Title (Title)"
# Click on Rewrite results
# Enable the checkbox for "Output this field as a custom link"
# Apply it
# Click on Translate View
# Click on add for respective language
# Click on: DEFAULT DISPLAY SETTINGS
# Click on: TITLE VIEWS ENTITY FIELD HANDLER
# Click on: REWRITE RESULTS
# User is not able to see Link path and link URL

Expected Results: The link URL in views must be translatable.

Actual Results: Currently The link URL in views is not translatable.

Please refer attached screenshots for the same.
Looks good to me.
Can be a move to RTBC.

Committed db660b7 and pushed to 9.3.x. Thanks!

ONly committed to 9.3.x as this requires a cache flush to work. We have an update function for the user module so a cache flsuh is already guaranteed for sites going to 9.3.0 so we don't need to add an empty post update here.