I think there is a use case for keeping the Name field visible in the site_setting_entity form - e.g. where the type allows multiple entities (e.g. Department contact details), a user may wish to name each entity for clarity (e.g. "Dev team", "UX team").

Site builders could choose to then use something like AutoEntity Label to auto-generate & hide the Name field if desired.

Patch attached keeps the name field visible & editable for entities of site setting types with the 'multiple' option checked.

CommentFileSizeAuthor
site_settings-name_editable.patch1.39 KBbgilhome

Issue fork site_settings-3007994

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

bgilhome created an issue. See original summary.

Status: Needs review » Needs work

The last submitted patch, site_settings-name_editable.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

scott_euser’s picture

scott_euser commented
Issue tags: +Needs tests

Thank you for your work on this. This will need updated tests to match it looks like, and would like to understand how the UI will change as a result; can you please attach before and after screenshots please? Thanks!

calebtr’s picture

calebtr commented

This patch still applies to the 8.x-1.x branch.

I'd be happy to work on screenshots and tests.

Maintainers, would you prefer to see this against the 2.x branch?

scott_euser’s picture

scott_euser commented

Sorry completely lost track of this (5 years ago it seems!). Yes please to 2x if you're willing to help out, thank you!

calebtr’s picture

calebtr commented
Version: 8.x-1.x-dev » 2.0.x-dev
Assigned: Unassigned » calebtr

calebtr changed the visibility of the branch 3007994-keep-name-field to hidden.

calebtr’s picture

calebtr commented
Assigned: calebtr » Unassigned

I took a closer look at the 2.x branch and I don't think we need to change anything. The administrative description field is sufficient to distinguish one site setting from another of the same type.

The Autoentity Label module seems to integrate just fine, after a cache refresh.

I recommend you close this as outdated, or else if a release for the 1.x branch is planned, we can leave it Needs Work and switch the version back on this ticket to that branch.

scott_euser’s picture

scott_euser commented
Status: Needs work » Closed (outdated)

Thanks for checking! Given there is an upgrade path to 2x seems like someone needing this can just upgrade so I think we can close. Thank you!