Problem/Motivation

Coding standards on file smtp.module

Proposed resolution

Refactory coding standards on file smtp.module

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#4 coding_standard_SMTP Authentication Support.png104.74 KBAanal.addweb
#2 coding_standards_on_file_smtp.module-3007715.patch1.53 KBthalles

Comments

Thalles created an issue. See original summary.

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
StatusFileSize
new coding_standards_on_file_smtp.module-3007715.patch1.53 KB

Follow the patch

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
Status: Needs work » Needs review
Aanal.addweb’s picture

Aanal.addweb commented
StatusFileSize
new coding_standard_SMTP Authentication Support.png104.74 KB

@Thalles, I checked your patch & match it with Pareview errors. Your patch is working fine for me as per the mentioned requirements. PFA

Aanal.addweb’s picture

Aanal.addweb commented
Status: Needs review » Reviewed & tested by the community
thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented

Thanks, @aanaladdweb!

wundo’s picture

wundo commented
Assigned: Unassigned » wundo
Status: Reviewed & tested by the community » Needs work

I think this still needs some work, on the patch, several comments look like this: "Function smtp_send_queue_runner.", which altough fixes the cs complaint don't add value to the codebase.

I'm working on a refactor of the whole .module file for D8, I think I will do this issue together with it.

wundo’s picture

wundo commented
wundo’s picture

wundo commented
Title: Coding standards on file smtp.module » Coding standards issues
wundo’s picture

wundo commented
Issue tags: -ciandt-contrib, -#ciandt-contrib
Parent issue: #3007710: Coding standards » #3081980: Plan for full 8.x-1.0 release of SMTP

  • wundo committed 944afa2 on 8.x-1.x 
    Issue #3007715 by wundo: Coding standards issues
  • wundo committed f479d32 on 8.x-1.x
    Issue #3007715 by wundo: Coding standards issues
japerry’s picture

japerry
Location KOMK
commented
Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.