Problem/Motivation

The issue happens when the following steps are followed:

  • The user clicks on "Ok" when the cookie notice is configured to show the following options to the user "Ok, I agree" and "No thanks"
  • Clicking on "Ok thanks" shows a thank you notice which is configured with two buttons "Hide" and "More info"
  • When clicking on "Hide", it will leave a white space in place of the notice instead of hiding it.

Proposed resolution

When the user clicks on "Hide", make sure the container div for the cookie notice is hidden too (using jQuery's hide method on the relevant div with id '#sliding-popup' when the user clicks on Hide and also once it has been agreed for future page loads)

Remaining tasks

The patch file needs to be created and attached to this issue -> patch file attached
Needs review

User interface changes

None

API changes

None

Data model changes

None

Patch update

Updated patch for v1.28 of the module

CommentFileSizeAuthor
#9 eu_cookie_compliance-cookie-notice-does-not-hide-properly-when-agreed-3007283-9-8.x.patch951 bytessvenryen
#9 eu_cookie_compliance-cookie-notice-does-not-hide-properly-when-agreed-3007283-9-7.x.patch917 bytessvenryen
#8 cookie_notice_not_hidden_when_agreed-3007283-2.patch972 byteshisamuran
#2 cookie_notice_not_hidden_when_agreed-3007283-1.patch1 KBhisamuran

Comments

hisamuran created an issue. See original summary.

hisamuran’s picture

hisamuran commented
Issue summary: View changes
StatusFileSize
new cookie_notice_not_hidden_when_agreed-3007283-1.patch1 KB
hisamuran’s picture

hisamuran commented
Status: Active » Needs review
svenryen’s picture

svenryen commented
Assigned: hisamuran » Unassigned
crawley’s picture

crawley commented

Still not working. Even after patch included. check www.myplace.co.ke. I had to disable the module. It was loading on every page even if I accepted. The only way to get rid of the message was to click on privacy settings until you visit another page and have to repeat the same process.

svenryen’s picture

svenryen commented

@crawley, can you check the Advanced settings and remove the domain if you've entered one. Most likely that's the reason why the banner loads on every page.

svenryen’s picture

svenryen commented

If you're still having issues, please run `drush vget eu_cookie_compliance` and share the output. Also, it seems your report is not really related to this issue.

hisamuran’s picture

hisamuran commented
Version: 7.x-1.25 » 7.x-1.28
Issue summary: View changes
StatusFileSize
new cookie_notice_not_hidden_when_agreed-3007283-2.patch972 bytes
svenryen’s picture

svenryen commented
StatusFileSize
new eu_cookie_compliance-cookie-notice-does-not-hide-properly-when-agreed-3007283-9-7.x.patch917 bytes
new eu_cookie_compliance-cookie-notice-does-not-hide-properly-when-agreed-3007283-9-8.x.patch951 bytes

I have improved your patch a little bit so that it works for both top and bottom pinned banners.

I also ported it to Drupal 8.

  • svenryen authored d4cf6d6 on 8.x-1.x 
    Issue #3007283 by hisamuran, svenryen: Cookie notice does not hide...

  • svenryen authored 98c1279 on 7.x-1.x 
    Issue #3007283 by hisamuran, svenryen: Cookie notice does not hide...
svenryen’s picture

svenryen commented
Status: Needs review » Fixed

  • svenryen authored 98c1279 on 7.x-2.x 
    Issue #3007283 by hisamuran, svenryen: Cookie notice does not hide...
branram’s picture

branram commented

@svenryen I tried applying the patches you gave to the 7.x-1.31 version and the banner does not hide upon pressing agree button still. Do we know if the fix will be committed to the latest version? Or any chance we can get a patch that works for the latest version?

svenryen’s picture

svenryen commented

branram - please run drush vget eu_cookie_compliance and paste the result here.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.