Problem/Motivation

All JavaScript in contributed code should follow JavaScript coding standards for Drupal.

Also leads to issues like TypeError: $ is not a function if used with local JS libraries ( see #3006601: Allow to use internal/local JS ).

Proposed resolution

Follow Drupal coding standards for JS and and wrap code in closure.

Remaining tasks

  1. Patch - Done
  2. Review
  3. Commit

User interface changes

None

API changes

None

Data model changes

None

CommentFileSizeAuthor
#2 modal_page-3006604-2.patch553 bytesrosk0

Comments

RoSk0 created an issue. See original summary.

rosk0’s picture

rosk0
he/him
Primary language Russian
Location Wellington
commented
Assigned: rosk0 » Unassigned
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new modal_page-3006604-2.patch553 bytes

Patch.

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +ciandt-contrib, +#ciandt-contrib

Thanks @RoSk0!
Very good! This patch work for me!

  • thalles committed 39953d7 on 7.x-1.x authored by RoSk0 
    Issue #3006604 by RoSk0, thalles: Follow Drupal coding standard for...
thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.