Problem/Motivation

In case website already using Bootstrap I want to be able to use internal library and hard coded CDN version.

Proposed resolution

Make usage of external CDN hosted libraries optional and configurable.

Remaining tasks

  1. Patch - Done
  2. Review
  3. Commit

User interface changes

Addition to configuration page.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#2 modal_page-3006601-2.patch1.58 KBrosk0

Comments

RoSk0 created an issue. See original summary.

rosk0’s picture

rosk0
he/him
Primary language Russian
Location Wellington
commented
Assigned: rosk0 » Unassigned
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new modal_page-3006601-2.patch1.58 KB

Patch.

renatog’s picture

renatog commented
Status: Needs review » Reviewed & tested by the community

Hello @RoSk0, how are you?!

Cooool man!!!

This patch is really good!

I was planning to create it! You guessed my thoughts.

Looks VERY good!

+RTBC.

Thank you very much for your contribution!

Good Work and Good Weekend.

Best,

renatog’s picture

renatog commented

P.s. @RoSk0: What do you think to create it for 8.x-2.x?

It'll help a lot the project!

Congrats, man!

  • thalles committed f1d9e80 on 7.x-1.x authored by RoSk0 
    Issue #3006601 by RoSk0, RenatoG: Allow to use internal/local JS
thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
Status: Reviewed & tested by the community » Fixed
Issue tags: +ciandt-contrib, +#ciandt-contrib

Patch very interesting, we even replicated it in the module version for Drupal 8.

Thanks @RoSk0 and @RenatoG!

renatog’s picture

renatog commented

Greeat!! Thanks a lot Thalles and @RoSk0

@Thalles; let's create one new release for D7?!

Thanks a lot. Good Weekend.

Best,

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.