While evaluating this project, I noticed the name of the project is not capitalized on the Extend page.

Capitalize the name of the module, because module names are proper nouns.
https://www.drupal.org/docs/develop/documenting-your-project/help-text-s...

Patch to follow ... Thanks

CommentFileSizeAuthor
#3 Screen Shot 2018-10-15 at 9.15.04 AM.png14.5 KBalonaoneill
#2 responsive_menu_combined-capitalizes-name-3006527-2.patch523 bytesvolkswagenchick

Comments

volkswagenchick created an issue. See original summary.

volkswagenchick’s picture

volkswagenchick
she/her
Primary language English
Location San Francisco Bay Area
commented
Assigned: volkswagenchick » Unassigned
Status: Active » Needs review
StatusFileSize
new responsive_menu_combined-capitalizes-name-3006527-2.patch523 bytes

I uploaded a patch that capitalizes the name of the module. Thanks!!

I also added a new line at the end of the file as per coding standards.

alonaoneill’s picture

alonaoneill commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Screen Shot 2018-10-15 at 9.15.04 AM.png14.5 KB

Code looks good, the name of the module is now capitalized on the Extend page. Screenshot provided."
The dependency namespacing aligns with Drupal documentation standards.
Marking as RTBC
Thank you for working on module!

istryker’s picture

istryker commented
Status: Reviewed & tested by the community » Fixed

Committed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.