[D8] Site Meta

Thank you for your contribution! May you describe the difference between this project and the Metatag module?

Looks good to me. However there is some indentation issue in function sitemeta_form_node_form_validate. But I think this module is good enough to covered in security advisory coverage.

There are just two points I find unclear.

/**
 * Implements hook_form_BASE_FORM_ID_alter().
 *
 * {@inheritdoc}
 */
function sitemeta_form_node_post_edit_form_alter(&$form, FormStateInterface $form_state) {
}

{@inheritdoc} is not used for hooks.
What form should that hook alter?

/**
 * Custom submit to save or update sitemeta entity.
 *
 * @param array $form
 *   Form object.
 * @param \Drupal\Core\Form\FormStateInterface $form_state
 *   Current form state.
 *
 * @throws \Drupal\Core\Entity\EntityStorageException
 */
function sitemeta_form_node_form_submit(array $form, FormStateInterface $form_state) {
}

That submission handler has not been added from a hook_form_alter(), hook_form_FORM_ID_alter(), or hook_form_BASE_FORM_ID_alter()implementation, so it would not be invoked.

Hi, I wrote a patch that addresses the issues written above.

The task of reviewers is reviewing code, not providing patches to fix what reported by other users.

/**
 * Implements hook_help().
 *
 * {@inheritdoc}
 */

{@inheritdoc} is not used for hooks.

  // Make sure we are on editing form.
  if ($node->isNew()) {
    return;
  }

Why would the code only change the node edit form when a node is edited, and when not a node is created. The settings make sense in both the cases.

  $form['sitemeta_settings'] = [
    '#type' => 'details',
    '#title' => t('Custom meta'),
    '#open' => FALSE,
    '#group' => 'advanced',
    '#access' => TRUE,
    '#weight' => 100,
  ];

#access is not necessary, in that case.

    $this->set('status', $published ? TRUE : FALSE);

It would be simpler to use $this->set('status', (bool) $published);.

I didn't find any security issue. I am going to approve this application in the next hours.

Thank you for your contribution! I am going to update your account.

These are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.