I'm seeing these warnings when using PHP 7.2:

Warning: count(): Parameter must be an array or an object that implements Countable in radix_table() (line 51 of /srv/www/html/build/html/sites/all/themes/contrib/radix/includes/structure.inc).

I'll provide a patch to address these.

CommentFileSizeAuthor
#3 interdiff-2-3.txt1.25 KBcboyden
#3 3005881-prevent-warnings-php72-3.patch2.19 KBcboyden
#2 3005881-prevent-warnings-php72.patch959 bytesberliner

Comments

berliner created an issue. See original summary.

berliner’s picture

berliner commented
Status: Active » Needs review
StatusFileSize
new 3005881-prevent-warnings-php72.patch959 bytes

Attached patch fixes the warnings for me and should also take care of more possible warnings in this section of the code.

cboyden’s picture

cboyden commented
StatusFileSize
new 3005881-prevent-warnings-php72-3.patch2.19 KB
new interdiff-2-3.txt1.25 KB

There are some other places in theme.inc where count is being called on incoming $variables that might not be arrays. I've patched this file using the same approach as @berliner.

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Status: Needs review » Reviewed & tested by the community

This patch looks good to me! With @cboyden's additions, I think this addresses all instances of count() where the type isn't sure to be an array

shadcn’s picture

shadcn commented
Assigned: Unassigned » dsnopek

David, this looks good. Can you commit this please?

  • dsnopek committed feab494 on 7.x-3.x authored by cboyden 
    Issue #3005881 by cboyden, berliner: Warnings PHP 7.2
dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Status: Reviewed & tested by the community » Fixed

Committed! Thanks, Everyone :-)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.