CommentFileSizeAuthor
#8 fontawesome-replace_deprecated_drupal_set_message-3005275-8.patch1005 bytesdaniel.moberly
#6 interdiff.txt290 bytesjhandsta
#4 fontawesome-replace_deprecated_drupal_set_message-3005275-4-D8.patch1.12 KBjhandsta
#2 replace_deprecated_drupal_set_message-3005275-2.patch1.12 KBkaruna patel

Comments

karuna patel created an issue. See original summary.

karuna patel’s picture

karuna patel commented
Status: Active » Needs review
StatusFileSize
new replace_deprecated_drupal_set_message-3005275-2.patch1.12 KB

Added patch to replace the deprecated drupal_set_message call with drupal messenger service as per drupal standard.

Status: Needs review » Needs work

The last submitted patch, 2: replace_deprecated_drupal_set_message-3005275-2.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

jhandsta’s picture

jhandsta commented
Status: Needs work » Needs review
StatusFileSize
new fontawesome-replace_deprecated_drupal_set_message-3005275-4-D8.patch1.12 KB

Fixes indent in the previous patch.

Status: Needs review » Needs work

The last submitted patch, 4: fontawesome-replace_deprecated_drupal_set_message-3005275-4-D8.patch, failed testing. View results

jhandsta’s picture

jhandsta commented
StatusFileSize
new interdiff.txt290 bytes
jhandsta’s picture

jhandsta commented
Status: Needs work » Needs review
daniel.moberly’s picture

daniel.moberly commented
StatusFileSize
new fontawesome-replace_deprecated_drupal_set_message-3005275-8.patch1005 bytes

Can't use $this->t() when not in object context, so I'm attaching a revised patch.

Thank you very much for your work thus far, joris!

Status: Needs review » Needs work

The last submitted patch, 8: fontawesome-replace_deprecated_drupal_set_message-3005275-8.patch, failed testing. View results

jhandsta’s picture

jhandsta commented
Status: Needs work » Reviewed & tested by the community

Tested and works!

  • Daniel.Moberly committed cb6c107 on 8.x-2.x 
    Issue #3005275 by joris.handstanger, karuna patel, Daniel.Moberly:...
daniel.moberly’s picture

daniel.moberly commented
Status: Reviewed & tested by the community » Fixed

Committed. Thanks all.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.