As #2071523: Fix Tests due to path changes is not about the testbot failure we see now and has more patch content then the probably fix I create this issue for the patch #2071523-11: Fix Tests due to path changes

Current status is schema violation according to test result https://www.drupal.org/pift-ci-job/1084436

onConfigSave
exception: [Uncaught exception] Line 95 of core/lib/Drupal/Core/Config/Development/ConfigSchemaChecker.php:
Drupal\Core\Config\Schema\SchemaIncompleteException:

Schema errors for tour.tour.tip-edit with the following errors:

tour.tour.tip-edit:tips.tour-page.attributes variable type is NULL but applied schema class is Drupal\Core\Config\Schema\Sequence in Drupal\Core\Config\Development\ConfigSchemaChecker->onConfigSave() (line 95 of /var/www/html/core/lib/Drupal/Core/Config/Development/ConfigSchemaChecker.php).

Drupal\Core\Config\Development\ConfigSchemaChecker->onConfigSave(Object, 'config.save', Object)
call_user_func(Array, Object, 'config.save', Object) (Line: 111)

Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher->dispatch('config.save', Object) (Line: 231)

Guess we need to unset Attributes

CommentFileSizeAuthor
#12 tour_ui-3004840-12.patch2.04 KBclemens.tolboom
#3 tour_ui-3004840-3.patch573 bytesclemens.tolboom
#2 tour_ui-2071523-11.patch551 bytesclemens.tolboom

Comments

clemens.tolboom created an issue. See original summary.

clemens.tolboom’s picture

clemens.tolboom
Primary language Dutch
Location Groningen, 🇳🇱/🇪🇺
commented
StatusFileSize
new tour_ui-2071523-11.patch551 bytes
clemens.tolboom’s picture

clemens.tolboom
Primary language Dutch
Location Groningen, 🇳🇱/🇪🇺
commented
StatusFileSize
new tour_ui-3004840-3.patch573 bytes
clemens.tolboom’s picture

clemens.tolboom
Primary language Dutch
Location Groningen, 🇳🇱/🇪🇺
commented
Status: Active » Needs review

The removed variant (no attributes) is exported with attributes: { } so I want to test against that too

  • clemens.tolboom committed bd2157e on 8.x-1.x 
    Issue #3004840 by clemens.tolboom: Fix testbot error about attributes
clemens.tolboom’s picture

clemens.tolboom
Primary language Dutch
Location Groningen, 🇳🇱/🇪🇺
commented
Status: Needs review » Fixed

I have no clue why

PHP 5.5 & MySQL 5.5, D8.6 Waiting for branch to pass

is not resolved so commit patch from #3 hoping it gets resolved.

  • clemens.tolboom committed 8643932 on 8.x-1.x 
    Issue #3004840 by clemens.tolboom: Fix testbot error about attributes
clemens.tolboom’s picture

clemens.tolboom
Primary language Dutch
Location Groningen, 🇳🇱/🇪🇺
commented

So now it complains about a string value.

onConfigSave
exception: [Uncaught exception] Line 95 of core/lib/Drupal/Core/Config/Development/ConfigSchemaChecker.php:
Drupal\Core\Config\Schema\SchemaIncompleteException: Schema errors for tour.tour.tour-edit with the following errors: tour.tour.tour-edit:tips.tour-page.attributes variable type is string but applied schema class is Drupal\Core\Config\Schema\Sequence in Drupal\Core\Config\Development\ConfigSchemaChecker->onConfigSave() (line 95 of

It is of no use to add new patch (as test will fail on main branch) so commit directly on branch 8.x-1.x to see better result.

clemens.tolboom’s picture

clemens.tolboom
Primary language Dutch
Location Groningen, 🇳🇱/🇪🇺
commented
Status: Fixed » Active

A reconfigured testing to use PHP 7.0 instead. So waiting for a succes or tips from our users.

  • clemens.tolboom committed 7abdf3f on 8.x-1.x 
    Issue #3004840 by clemens.tolboom: Fix testbot error about attributes
clemens.tolboom’s picture

clemens.tolboom
Primary language Dutch
Location Groningen, 🇳🇱/🇪🇺
commented

There where two empty attributes ... sigh.

clemens.tolboom’s picture

clemens.tolboom
Primary language Dutch
Location Groningen, 🇳🇱/🇪🇺
commented
Status: Active » Needs review
StatusFileSize
new tour_ui-3004840-12.patch2.04 KB

Branch test is now testing code from the tests instead of barking about attributes.

Attached patch does harness attributes and test the ConfigSchemaChecker with attributes : { } as that's the config export value.

Status: Needs review » Needs work

The last submitted patch, 12: tour_ui-3004840-12.patch, failed testing. View results

  • clemens.tolboom committed eb4de68 on 8.x-1.x 
    Issue #3004840 by clemens.tolboom: Fix testbot error about attributes
clemens.tolboom’s picture

clemens.tolboom
Primary language Dutch
Location Groningen, 🇳🇱/🇪🇺
commented
Status: Needs work » Fixed

  • clemens.tolboom committed 0085672 on 8.x-1.x 
    Issue #3004840 by clemens.tolboom: Fix testbot error about attributes

  • clemens.tolboom committed bdc5082 on 8.x-1.x 
    Issue #3004840 by clemens.tolboom: Fix testbot error about attributes
clemens.tolboom’s picture

clemens.tolboom
Primary language Dutch
Location Groningen, 🇳🇱/🇪🇺
commented
Title: Fix testbot error about attributes » Fix testbot errors
Status: Fixed » Needs work

Testbot is not happy in general so reopening until tests are running fine.

  • clemens.tolboom committed 77640f2 on 8.x-1.x 
    Issue #3004840 by clemens.tolboom: Fix testbot error about attributes

  • clemens.tolboom committed ca1a824 on 8.x-1.x 
    Issue #3004840 by clemens.tolboom: Fix testbot error about attributes
clemens.tolboom’s picture

clemens.tolboom
Primary language Dutch
Location Groningen, 🇳🇱/🇪🇺
commented

Applied CR https://www.drupal.org/node/2315865
Later please do CR https://www.drupal.org/node/2301125

  • clemens.tolboom committed b7c5afd on 8.x-1.x 
    Issue #3004840 by clemens.tolboom: Fix testbot error about attributes (...

  • clemens.tolboom committed 135aea7 on 8.x-1.x 
    Issue #3004840 by clemens.tolboom: There are no linked path but routes
clemens.tolboom’s picture

clemens.tolboom
Primary language Dutch
Location Groningen, 🇳🇱/🇪🇺
commented

I close this as the test bot is happy. Our tests are not good anymore. But that's another issue.

clemens.tolboom’s picture

clemens.tolboom
Primary language Dutch
Location Groningen, 🇳🇱/🇪🇺
commented
Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.