Fix Tests due to path changes

Path on */edit are listed in test results as 404

Test on ie #71: admin/config/user-interface/tour/add
Current OK-ed Test
GET http://drupal.d8/admin/config/user-interface/tour/manage/fj0awosg/edit returned 404 (4.82 KB).

So this needs some fixes.

#2026239: Display the tour file name on the Tour UI overview page added the tour file short name (without tour.tour. prefix).

Other tests are broken with mostly XPath errors.
- the result page is empty (I don't get these)
- the create new tour fails completely :-/

The exceptions are about

[Sun Sep 08 15:12:33 2013] [error] [client 127.0.0.1] PHP Fatal error:  Call to undefined method Drupal\\tour_test\\Plugin\\tour\\tip\\TipPluginImage::export() in /Users/clemens/Sites/drupal/d8/www/sites/default/modules/tour_ui/lib/Drupal/tour_ui/TourFormController.php on line 92
[Sun Sep 08 15:12:33 2013] [error] [client 127.0.0.1] PHP Stack trace:
[Sun Sep 08 15:12:33 2013] [error] [client 127.0.0.1] PHP   1. {main}() /Users/clemens/Sites/drupal/d8/www/index.php:0
[Sun Sep 08 15:12:33 2013] [error] [client 127.0.0.1] PHP   2. drupal_handle_request() /Users/clemens/Sites/drupal/d8/www/index.php:15
[Sun Sep 08 15:12:33 2013] [error] [client 127.0.0.1] PHP   3. Drupal\\Core\\DrupalKernel->handle() /Users/clemens/Sites/drupal/d8/www/core/includes/bootstrap.inc:1862
[Sun Sep 08 15:12:33 2013] [error] [client 127.0.0.1] PHP   4. Drupal\\Core\\HttpKernel->handle() /Users/clemens/Sites/drupal/d8/www/core/lib/Drupal/Core/DrupalKernel.php:281
[Sun Sep 08 15:12:33 2013] [error] [client 127.0.0.1] PHP   5. Symfony\\Component\\HttpKernel\\HttpKernel->handle() /Users/clemens/Sites/drupal/d8/www/core/lib/Drupal/Core/HttpKernel.php:52
[Sun Sep 08 15:12:33 2013] [error] [client 127.0.0.1] PHP   6. Symfony\\Component\\HttpKernel\\HttpKernel->handleRaw() /Users/clemens/Sites/drupal/d8/www/core/vendor/symfony/http-kernel/Symfony/Component/HttpKernel/HttpKernel.php:61
[Sun Sep 08 15:12:33 2013] [error] [client 127.0.0.1] PHP   7. call_user_func_array() /Users/clemens/Sites/drupal/d8/www/core/vendor/symfony/http-kernel/Symfony/Component/HttpKernel/HttpKernel.php:117
[Sun Sep 08 15:12:33 2013] [error] [client 127.0.0.1] PHP   8. Drupal\\tour_ui\\Routing\\TourUIController->edit() /Users/clemens/Sites/drupal/d8/www/core/vendor/symfony/http-kernel/Symfony/Component/HttpKernel/HttpKernel.php:117
[Sun Sep 08 15:12:33 2013] [error] [client 127.0.0.1] PHP   9. entity_get_form() /Users/clemens/Sites/drupal/d8/www/sites/default/modules/tour_ui/lib/Drupal/tour_ui/Routing/TourUIController.php:64
[Sun Sep 08 15:12:33 2013] [error] [client 127.0.0.1] PHP  10. Drupal\\Core\\Entity\\EntityManager->getForm() /Users/clemens/Sites/drupal/d8/www/core/includes/entity.inc:540
[Sun Sep 08 15:12:33 2013] [error] [client 127.0.0.1] PHP  11. drupal_build_form() /Users/clemens/Sites/drupal/d8/www/core/lib/Drupal/Core/Entity/EntityManager.php:369
[Sun Sep 08 15:12:33 2013] [error] [client 127.0.0.1] PHP  12. drupal_retrieve_form() /Users/clemens/Sites/drupal/d8/www/core/includes/form.inc:384
[Sun Sep 08 15:12:33 2013] [error] [client 127.0.0.1] PHP  13. call_user_func_array() /Users/clemens/Sites/drupal/d8/www/core/includes/form.inc:869
[Sun Sep 08 15:12:33 2013] [error] [client 127.0.0.1] PHP  14. Drupal\\Core\\Entity\\EntityFormController->buildForm() /Users/clemens/Sites/drupal/d8/www/core/includes/form.inc:869
[Sun Sep 08 15:12:33 2013] [error] [client 127.0.0.1] PHP  15. Drupal\\tour_ui\\TourFormController->form() /Users/clemens/Sites/drupal/d8/www/core/lib/Drupal/Core/Entity/EntityFormController.php:98

I've added two fixes but the exception from #3 needs more work.

From the tipTest() output I get a Drupal\Component\Plugin\Exception\PluginException: Unknown plugin ID 'tour-ui-test-image-tip'. in Drupal\Component\Plugin\DefaultPluginBag->initializePlugin() (line 79 of /Users/clemens/Sites/drupal/d8/www/core/lib/Drupal/Component/Plugin/DefaultPluginBag.php).

Attached patch should reduce
from FAILED: [[SimpleTest]]: [MySQL] 39 pass(es), 47 fail(s), and 4 exception(s).
to 73 passes, 16 fails, 8 exceptions, and 22 debug messages

So patch will be committed shortly.

This is weird. Both patches from #2and #4 are now scheduled for testing.

#2 https://qa.drupal.org/pifr/test/619643
#4 https://qa.drupal.org/pifr/test/619653

Next time I'll commit immediately I should not add a patch or one with donottest ?

In our tests we enable tour_test module which provides an image plugin style. But we do not have an editor for this.

I'm not sure whether this is a core bug as TipPluginImage has a different signature then TipPluginText.

namespace Drupal\tour_test\Plugin\tour\tip;

use Drupal\Core\Annotation\Translation;
use Drupal\tour\Annotation\Tip;
use Drupal\tour\TipPluginBase;

/**
 * Displays an image as a tip.
 *
 * @Tip(
 *   id = "image",
 *   title = @Translation("Image")
 * )
 */
class TipPluginImage extends TipPluginBase {

namespace Drupal\tour\Plugin\tour\tip;

use Drupal\Core\Annotation\Translation;
use Drupal\Core\Plugin\ContainerFactoryPluginInterface;
use Drupal\Core\Utility\Token;
use Drupal\tour\Annotation\Tip;
use Drupal\tour\TipPluginBase;
use Symfony\Component\DependencyInjection\ContainerInterface;

/**
 * Displays some text as a tip.
 *
 * @Tip(
 *   id = "text",
 *   title = @Translation("Text")
 * )
 */
class TipPluginText extends TipPluginBase implements ContainerFactoryPluginInterface {

8.x-1.x Failed FAILED: [[SimpleTest]]: [MySQL] 44 pass(es), 19 fail(s), and 42 exception(s). 22/09/2013 - 12:06

Tag this with needs tests to find it back later

[edit]moved to #3004840: Fix testbot errors

Let's see whether we can kick the test with a removed attribute.

Trying to reimport the wrong tour file shows the same failure. Applying the patch makes manually re-import work. Yeah.

Back to the work done before the temp patch from #11.

Patch #4 is fixed through #2182095: Fix Tour UI to work on latest core