Fix Tour UI to work on latest core

I only stayed current until Jan 24. http://drupalpatio.com/im24

Tried #4 but with no results. Drush doesn't seem to want to apply the patch. Working off latest version of D8 and latest version of tour module. Starting to get the strong impression that this part of D8 needs a lot of work. Just enabling tour_ui seemed to create a lot of problems on my localhost. Also once installed, it seems it doesn't want un-enable / un-install. The tour_ui module maintainers need to release a more stable working copy so those of us who aren't native developers, but are keen to start writing lots of tours for the community and also write general documentation can start doing this.

My gut feeling is to wait on the BETA or RC release. This shouldn't be holding back writing tour's for core.

There are many ways to contribute tours to core (screenshots etc), the hardest part is working out what you write. I have been stretch on other Drupal community projects recently, but plan to focus on this in the coming weeks in the lead up to DrupalCon Amsterdam.

With D8 now on Beta 6 and Beta 7 due out on Feb 25 I may get back on this. I stopped work on the UI for the Advanced Tour last March and lately I've been considering getting back up to speed on D8.

Critical, surely?

I whipped up a new tour_ui for the beta7 version of drupal 8 to get back up to speed on stuff. Its completely new and has zippo to do with the one stopped back in Oct of 2013. Screen recording can be seen at http://d8pres.qetm.biz/tour_ui

Agreed, would really love to see that code committed back to this project!

@slewazimuth,

Video looks awesome! I will contact you once Im back from DrupalCI sprinting (next week).

I'm running a copy of Drupal head master and install this module + patch and I got this error.

ReflectionException: Class Drupal\tour_ui\Routing\TourUIController does not exist in ReflectionClass->__construct() (line 964 of /Sites/drupal/core/vendor/symfony/dependency-injection/ContainerBuilder.php).

Nick never did contact me, but while waiting I built a new Advanced Tour, Advanced Tour UI along with a number of other modules for Drupal 8 to support Intermedia. With Release Candidate 1 being released, here's the latest silent screen recording showing a bit of the Advanced Tour on RC1 - http://d8pres.qetm.biz/rc1

After a couple days of work, here is a large rewrite of tour_ui module ported to Drupal 8.2.x.

Tests will have to be converted to phpunit. I suggest to create a new issue for tests after this port will be commited.

Have a nice tour !

Tests fail due to... tour_ui (simpletest) tests.

Please review and commit this code first before tests can be rewritten. Right now module can't be used so tests are pointless.

Tour lose routes when user click on 'Add' tip button.

Fix a missing replacement from _tour_load to Tour Class load.

Add Tour UI to User-interface menu.

Add #delta => 100 to tip weight to not be in conflict with drag&drop table weight from tour form.

Check tip implements methods export() and optionsForm() to define if a tip can be edited or added. At this point, tips without export() will be lost, so we need work to get list of tip independent of export method. If tip has not export method, we should use existing tip definition.

I remove src/Plugin/tour/tip/TipPluginTextExtended as Tour tip plugin and replace it by tour_ui plugin src/Plugin/tour_ui/tip/TipPluginTextExtended. TipPluginTextExtended should not be defined as Tour tip plugin since its purpose is only to extends TipPluginText. It should not appear in available plugins, and once tour_ui is disabled (should be disabled in production), text tip should still appear, which is not the case without that.

With this patch
* I replace export() method by getConfiguration(), waiting after #2851166. When this one will be commited getConfiguration() will be useless in each plugins.
* A warning is displayed in tour UI when a tip is not exportable. Tour cannot be saved in this case to avoid unwanted tip deletion.

And finally small fix for coding standard, removing tab and adding line at end of files.

There is many differences and modifications so -M does not give many more.

why do yo want to move files ? i you do that, patch will fail

I have applied that and hey it works in 8.26, again! Grat patch!

We find a usage for this module, and therefor I have forked it, and added @Goz patch, more about it in #2857224: Fork of Tour UI.

There are a bunch of fixes to get Tour UI up to speed, that is why I forked it, you will need to combine patches to get the thing working, and that is why I think a fork is the best idea, and then make a big patch from it, that hopefully will be accepted byt the maintainers here. And yes collaborating is the key, so please help out if you want to, the github repo will be up later today.

I don't think a big patch with lot of features is a good deal.
It will be hard to read and review.

@clemens.tolboom Tour UI doesn't work anymore, can you at least commit this current patch so we can go forward and fix issues or features in different issues ? I agree to co-maintain if you want.

Not working anymore..

I think Tour UI is abandoned. There hasn't been a commit in 3 years, and there's been no move by maintainers to merge any of the changes in this thread that reports that the module is un-usable. That doesn't sound like "actively maintained" to me.

There was a fork a few months back (#36), but there haven't been any commits there since the fork either...

I have been quite occupied and going to work on the fork during the summer.

Great to push this forward.

I've added GoZ as co-maintainer and upgraded clemens' permissions so that he can add new maintainers himself in the future.

thanks dddave

Well, the issue in the Project ownership queuesummoned me. ;)
I took a look around the module's queue and assessed the situation (and forget to post in the other issue...). After all the module was quite broken, yet you were the acting maintainer and willing to add new co-maintainers.