Problem/Motivation

In behavior_settings.schema.yml the rabbit_hole.behavior_settings.* uuid property is defined as a string. However, this overrides the config_entity config schema for this property, losing the constraint validation added in #2870878: Add config validation for UUIDs

Proposed resolution

Remove the uuid property from the rabbit_hole.behavior_settings config entity schema, so its definition is provided by the config_entity data type. This results in less code for Rabbit Hole and improves uuid data support.

Remaining tasks

  1. Write a patch
  2. Review
  3. Commit

User interface changes

None.

API changes

None.

Data model changes

The uuid property of rabbit_hole.behavior_settings now has constraints by Drupal core.

CommentFileSizeAuthor
#2 rabbit_hole-uuid_config_schema-3004012-2.patch799 bytesidebr
#2 3004012-after.png42.85 KBidebr
#2 3004012-before.png43.57 KBidebr

Comments

idebr created an issue. See original summary.

idebr’s picture

idebr commented
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new 3004012-before.png43.57 KB
new 3004012-after.png42.85 KB
new rabbit_hole-uuid_config_schema-3004012-2.patch799 bytes

Attached patch removes the uuid property from the rabbit_hole.behavior_settings config entity schema, so its definition is provided by the config_entity data type. This results in less code for Rabbit Hole and improves uuid data support.

Before:

After:

jeroent’s picture

jeroent
Primary language Dutch
Location 🇧🇪
commented
Status: Needs review » Reviewed & tested by the community

Patch looks sane to me.

dylan donkersgoed’s picture

dylan donkersgoed commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.