Drupal Coder/PHPCS Updates

Drupal Coder has been updated to ^8.3.1
By updating Drupal Coder, PHPCS (php_codesniffer) has been updated to ^3.4.1

PHPCS 2.x, doesn't support PHP 7.3 and PHPCS 3.x has been out for more than a year now.

For any projects using custom phpcs.xml/standards, see: Upgrade Guide.

Specifically impacting Drupal Core, the array sniffs were renamed from Drupal.Array.Array... to Drupal.Arrays.Array... so the following changes were made in phpcs.xml.dist - line 27:

-  <rule ref="Drupal.Array.Array">
+  <rule ref="Drupal.Arrays.Array">
     <!-- Sniff for these errors: CommaLastItem -->
-    <exclude name="Drupal.Array.Array.ArrayClosingIndentation"/>
-    <exclude name="Drupal.Array.Array.ArrayIndentation"/>
-    <exclude name="Drupal.Array.Array.LongLineDeclaration"/>
+    <exclude name="Drupal.Arrays.Array.ArrayClosingIndentation"/>
+    <exclude name="Drupal.Arrays.Array.ArrayIndentation"/>
+    <exclude name="Drupal.Arrays.Array.LongLineDeclaration"/>

Also, added to phpcs.xml.dist - line 209:

+  <rule ref="PEAR.Functions.FunctionCallSignature.OpeningIndent">
+    <severity>0</severity>
+  </rule>

Some minor changes were made in the general Drupal code base to support misc minor changes in PHPCS sniffs.