Problem/Motivation

As there is a new method to invalidate twig cache we should use it in the module. See https://www.drupal.org/node/2908461

Proposed resolution

Change:

PhpStorageFactory::get('twig')->deleteAll();

by

\Drupal::service('twig')->invalidate();

Remaining tasks

None.

User interface changes

None.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#3 admin_toolbar-invalidate_twig-3003678-3-D8.patch3.77 KBromainj
#2 admin_toolbar-invalidate_twig-3003678-2-D8.patch1.43 KBadriancid

Comments

adriancid created an issue. See original summary.

adriancid’s picture

adriancid
Primary language Spanish
Location Qc, Canada 🇨🇦
commented
Status: Active » Needs review
StatusFileSize
new admin_toolbar-invalidate_twig-3003678-2-D8.patch1.43 KB
romainj’s picture

romainj commented
StatusFileSize
new admin_toolbar-invalidate_twig-3003678-3-D8.patch3.77 KB

New patch with dependency injection.

adriancid’s picture

adriancid
Primary language Spanish
Location Qc, Canada 🇨🇦
commented

Thanks @romainj is better now, when do you think we should commit this patch? Once Drupal 8.7 will be released?

romainj’s picture

romainj commented

@adriancid Yes we should wait for D8.7 release at least.

adriancid’s picture

adriancid
Primary language Spanish
Location Qc, Canada 🇨🇦
commented
Status: Needs review » Reviewed & tested by the community

  • adriancid committed b08184c on 8.x-1.x authored by romainj 
    Issue #3003678 by adriancid, romainj: New method to invalidate twig...
adriancid’s picture

adriancid
Primary language Spanish
Location Qc, Canada 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed
adriancid’s picture

adriancid
Primary language Spanish
Location Qc, Canada 🇨🇦
commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.