Problem/Motivation

Paragraphs Collection directly integrates with select2 library in paragraphs_collection_libraries_info().

Since recently, there is a Drupal module that provides integration with Select2 library.

Among other things, it provides better styling for the default admin (Seven) theme. See #3001987: Do not use own design.

Proposed resolution

Paragraphs Collection should try to rely on select2 module instead directly using the library.

Keep in mind that we should not add a dependency to the module but only (re)use it if the module is available/enabled.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#4 3003494-use-select2-module-4.patch7.64 KBPrimsi
#4 3003494-use-select2-module-3.interdiff.txt1.12 KBPrimsi
#3 3003494-use-select2-module.png42.93 KBPrimsi
#3 3003494-use-select2-module-3.patch7.6 KBPrimsi
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mbovan created an issue. See original summary.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented

So the idea would be that we drop our own custom select2 library and styling, and then in the form, we do something like this (pseudo code):

if (select2 module exists) {
  use #type select2
}
else {
 use #type select
}
Primsi’s picture

Primsi CreditAttribution: Primsi at MD Systems GmbH for MD Systems GmbH commented
Status: Active » Needs review
FileSize
3003494-use-select2-module-3.patch7.6 KB
3003494-use-select2-module.png42.93 KB

select2

Primsi’s picture

Primsi CreditAttribution: Primsi at MD Systems GmbH for MD Systems GmbH commented
FileSize
3003494-use-select2-module-3.interdiff.txt1.12 KB
3003494-use-select2-module-4.patch7.64 KB

Added width auto.

  • Berdir committed 6d0b18d on 8.x-1.x authored by Primsi 
    Issue #3003494 by Primsi: Integrate with select2 module
Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Needs review » Fixed

Nice :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.