The text filter, used for html text formats, applies obfuscation properly on a plain text email address (mail@example.com) and an email address enclosed in the <a> tag (<a href="mailto:mail@example.com">mail@example.com</a>).

The obfuscation support have to be extended to a text enclosed in the <a> tag (<a href="mailto:mail@example.com">Contact us</a>).

CommentFileSizeAuthor
#4 support-mailto-links-another-text-value-3003457-4.patch2.27 KBmrshowerman
#3 support-mailto-links-another-text-value-3003457-3.patch5.38 KBvidorado

Comments

colorfield created an issue. See original summary.

colorfield’s picture

colorfield
Primary language French
Location Lausanne
commented
Issue summary: View changes
vidorado’s picture

vidorado commented
StatusFileSize
new support-mailto-links-another-text-value-3003457-3.patch5.38 KB

Dirty patch for those using ROT13 method

Caution: ¡¡It breaks HTMLEntities method!!

mrshowerman’s picture

mrshowerman
Location Munich
commented
StatusFileSize
new support-mailto-links-another-text-value-3003457-4.patch2.27 KB

I see some work has been done in current HEAD, but there's no support for the filter.
Attached patch solves this.

mrshowerman’s picture

mrshowerman
Location Munich
commented
Status: Active » Needs review
nigelcunningham’s picture

nigelcunningham commented

I've just completed a bit of a rewrite, including changes in this area. Please test the 2.0.x dev branch.

Thanks!

mrshowerman’s picture

mrshowerman
Location Munich
commented

I tested the 2.0.x branch and it works nicely.

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Status: Needs review » Reviewed & tested by the community

Hi,

I applied patch from comment 4 on 2.0.0 version and it fixes the bug.

Thanks!

nigelcunningham’s picture

nigelcunningham commented
Status: Reviewed & tested by the community » Postponed (maintainer needs more info)

Hi @Grimreaper.

I've just tried applying the patch and am not seeing a case where it still makes any difference - it applies, but doesn't seem to make any difference to the output. Could you help me out with a case where you're still seeing an issue without the patch being applied?

Thanks!

Nigel

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented

Hi @Nigel Cunningham,

The following code in the RTE:

<a href="mailto:example@example.com">write us</a>

Before patch, will produce:

<a href="mailto:example@example.com" rel="nofollow">example@example.com</a>

After patch, will produce:

<a href="mailto:example@example.com" rel="nofollow">write us</a>

Hope this help.

Thanks :)

nigelcunningham’s picture

nigelcunningham commented
Status: Postponed (maintainer needs more info) » Active
nigelcunningham’s picture

nigelcunningham commented
Status: Active » Postponed (maintainer needs more info)

Morning Grimreaper.

Apologies first for the delay in getting back to this.

I've just enabled Obfuscate afresh in my module dev install, added the Obfuscate filter to the end of the Basic HTML configuration and put "write us" in the source of a normal node's WYSIWYG, using basic HTML for the format. On the resulting page, the source shows:


write us

Could I get you to point out what I'm doing differently? The commit I'm on is fa512f3b (2.0.x branch)

Thanks!

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented

Hi @Nigel Cunningham,

No problem for the reply delay.

Since the last comment even with patch the problem still occured randomly so I gave up on using Obfuscate and uninstalled it.

I was on 2.0.0 version and I also had the "Convert URLs into links" filter enabled.

If on another project I will have to use Obfuscate and still got the problem, I will give news.

nigelcunningham’s picture

nigelcunningham commented

Thanks!

I'll try again with the info you provided.