While testing for #2994408: Tips don't save edits I did not manage to get to the Edit screen like http://drupal.d8/admin/config/user-interface/tour/manage/views-ui/tip/ed...

Debugging showed the code was wrong. Is this for Drupal 8.6.1 specific?

CommentFileSizeAuthor
#2 tour_ui-3003288-1.patch889 bytesclemens.tolboom

Comments

clemens.tolboom created an issue. See original summary.

clemens.tolboom’s picture

clemens.tolboom
Primary language Dutch
Location Groningen, 🇳🇱/🇪🇺
commented
Status: Active » Needs review
Issue tags: +Needs tests
StatusFileSize
new tour_ui-3003288-1.patch889 bytes
clemens.tolboom’s picture

clemens.tolboom
Primary language Dutch
Location Groningen, 🇳🇱/🇪🇺
commented

Checking with core Tour there seems no changes. Maybe core #2246647: Rename PluginBag to LazyPluginCollection did something.

+++ b/src/Controller/TourTipController.php
@@ -109,9 +110,9 @@ class TourTipController extends ControllerBase implements ContainerInjectionInte
-    $tips = array_keys($tour->getTips());
-    if (!in_array($tip, $tips)) {

There are no keys. So this should have failed a long time maybe introduces and got unnoticed in #2182095: Fix Tour UI to work on latest core

So I commit this patch

clemens.tolboom’s picture

clemens.tolboom
Primary language Dutch
Location Groningen, 🇳🇱/🇪🇺
commented
Status: Needs review » Fixed
clemens.tolboom’s picture

clemens.tolboom
Primary language Dutch
Location Groningen, 🇳🇱/🇪🇺
commented
Version: 8.x-1.x-dev » 8.x-1.0-beta1

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.