This is a bug we're inheriting from core. If you have multiple product types (or any other bundle), the view shows you a Type filter. That filter will show product types that you can't view (guaranteeing an empty table), cause there's no access check performed.

Since we have our own EntityBundle handler which inherits the core one, let's add a fix there.

CommentFileSizeAuthor
#6 3003105-6-bundle-access.patch6.83 KBbojanz
#4 interdiff-2-4.txt873 bytesczigor
#4 commerce-3003105-bundle_filter-4.patch9.6 KBczigor
#2 commerce-3003105-bundle_filter-2.patch9.6 KBczigor

Comments

bojanz created an issue. See original summary.

czigor’s picture

czigor commented
Status: Active » Needs review
StatusFileSize
new commerce-3003105-bundle_filter-2.patch9.6 KB
bojanz’s picture

bojanz commented
Status: Needs review » Needs work 
+        $entity = $this->entityManager->getStorage($this->entityTypeId)->create([$this->entityType->getKey('bundle') => $type]);
+        if (!$this->options['expose']['filter_bundles'] || $entity->access('view')) {

We construct the entity even if we don't need it (when filter_bundles is off). This is not a cheap operation, let's skip it.

czigor’s picture

czigor commented
Status: Needs work » Needs review
StatusFileSize
new commerce-3003105-bundle_filter-4.patch9.6 KB
new interdiff-2-4.txt873 bytes
bojanz’s picture

bojanz commented
Related issues: +#3099068: The "bundle" views filter shows options the user doesn't have access to

Opened a core issue: #3099068: The "bundle" views filter shows options the user doesn't have access to.

bojanz’s picture

bojanz commented
StatusFileSize
new 3003105-6-bundle-access.patch6.83 KB

Let's reboot the patch.

Kept (and re-arranged a bit) the test coverage. Tweaked the fix so that it's not optional, but only applies to exposed filters.

bojanz’s picture

bojanz commented
Status: Needs review » Fixed

Committed.

  • bojanz committed 28eaaa8 on 8.x-2.x authored by czigor 
    Issue #3003105 by czigor, bojanz: The views bundle (type) filter shows...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.