Closed (fixed)
Project:
Drupal core
Version:
8.6.x-dev
Component:
layout_builder.module
Priority:
Major
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
27 Sep 2018 at 21:19 UTC
Updated:
9 Nov 2018 at 09:54 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
tedbowHere is test only patch that fails.
Comment #3
tedbowComment #4
tim.plunkettI could have sworn we had an issue for this already, but I can't find it.
When a view mode is enabled, it copies all the values from the default view mode.
So if LB is enabled for the default, it will be for the new one. And then it also copies over the sections from the default, before going through and initializing all the fields as new components...
Comment #6
tim.plunkett#2990517-3: Adding a display mode to a content type using layout, and disabling layout on that new display mode removes the layout_builder__layout field and breaks layout in already configured display modes. was the issue I was remembering. That issue is about what happens when trying to get around this bug, and is way worse (data loss!).
I haven't compared the test from this and that issue, but I bet they are similar.
Comment #7
xjmThis sounds major or critical; marking critical pending feedback.
Comment #8
chipway commentedWhen I follow the summary test process (before patching), I get a WSOD, while other site pages work.
PDOException: PDO::__construct(): php_network_getaddresses: getaddrinfo failed: Name or service not known in [error]
/core/lib/Drupal/Core/Database/Driver/mysql/Connection.php:420
...
Strange.
Comment #9
tim.plunkettThis isn't critical at all, but if you get frustrated by this and try to start over, you could easily hit #2990517: Adding a display mode to a content type using layout, and disabling layout on that new display mode removes the layout_builder__layout field and breaks layout in already configured display modes. which IS critical. Settling on major for now.
This is postponed on the above.
Comment #10
tim.plunkettComment #11
tim.plunkettActually not postponed on that, not sure what I was thinking.
Comment #13
tim.plunkettHad a test depending on the old behavior :)
Comment #14
tedbowFix looks good!
Comment #16
larowlannice we were relying on the side effect
Committed 19513d5 and pushed to 8.7.x. Thanks!
c/p as 7f448d596d for 8.6.x