Drupal files are no longer set to temporary by default after all usages removed, see https://www.drupal.org/node/2891902.
Causing failure of assertion in IconFileUsageTest::testEmbedButtonIconUsage()
two examples from issue queue for embed module:
https://www.drupal.org/pift-ci-job/1019781
https://www.drupal.org/pift-ci-job/1072907
There was 1 failure:
1) Drupal\Tests\embed\Kernel\IconFileUsageTest::testEmbedButtonIconUsage
Failed asserting that false is true.
/var/www/html/core/tests/Drupal/KernelTests/AssertLegacyTrait.php:31
/var/www/html/modules/contrib/embed/tests/src/Kernel/IconFileUsageTest.php:57
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | embed-assertion-fails-fix-3002291-5.patch | 629 bytes | oknate |
Comments
Comment #2
oknateComment #3
oknateComment #4
oknateComment #5
oknateThere was a standards error reported saying there was a double space. Fixed that.
Comment #6
oknateI also worked this patch into patch #19 for https://www.drupal.org/project/embed/issues/2824110.
Comment #7
joegraduateWorks for me. I've added this fix to the latest patch for #3042596: Drupal 9 Deprecated Code Report. Also upgrading this to "major" since it's likely to affect every single issue/patch until resolved.
Comment #8
joegraduateComment #10
dave reidCommitted #5 to 8.x-1.x.