Drupal files are no longer set to temporary by default after all usages removed, see https://www.drupal.org/node/2891902.

Causing failure of assertion in IconFileUsageTest::testEmbedButtonIconUsage()

two examples from issue queue for embed module:
https://www.drupal.org/pift-ci-job/1019781

https://www.drupal.org/pift-ci-job/1072907

There was 1 failure:

1) Drupal\Tests\embed\Kernel\IconFileUsageTest::testEmbedButtonIconUsage
Failed asserting that false is true.

/var/www/html/core/tests/Drupal/KernelTests/AssertLegacyTrait.php:31
/var/www/html/modules/contrib/embed/tests/src/Kernel/IconFileUsageTest.php:57

Comments

oknate created an issue. See original summary.

oknate’s picture

StatusFileSize
new614 bytes
oknate’s picture

Status: Active » Needs review
oknate’s picture

Issue summary: View changes
oknate’s picture

StatusFileSize
new629 bytes

There was a standards error reported saying there was a double space. Fixed that.

oknate’s picture

I also worked this patch into patch #19 for https://www.drupal.org/project/embed/issues/2824110.

joegraduate’s picture

Priority: Normal » Major
Status: Needs review » Reviewed & tested by the community

Works for me. I've added this fix to the latest patch for #3042596: Drupal 9 Deprecated Code Report. Also upgrading this to "major" since it's likely to affect every single issue/patch until resolved.

joegraduate’s picture

Title: Test fails after change in Drupal 8.4 » IconFileUsageTest fails after change in Drupal 8.4

  • Dave Reid committed bf75e20 on 8.x-1.x authored by oknate
    Issue #3002291 by oknate: Fixed IconFileUsageTest fails after change in...
dave reid’s picture

Status: Reviewed & tested by the community » Fixed

Committed #5 to 8.x-1.x.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.