Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
Debugging requests made to the installer pages in InstallerTestBase does not work because the xdebug cookies are not set up.
Proposed resolution
Fix it by moving the cookie setting into initMink
Test instructions
- enable xdebug
- set a breakpoint in install_begin_request
- run core/tests/Drupal/FunctionalTests/Installer/MinimalInstallerTest.php
Remaining tasks
User interface changes
None
API changes
None
Data model changes
None
Comment | File | Size | Author |
---|---|---|---|
#2 | 3002279-2.patch | 3.87 KB | alexpott |
Comments
Comment #2
alexpottWe should also take this opportunity to make it simpler to keep UpgradePathTestBase InstallTestBase and BrowserTestBase tests all in sync.
Comment #3
alexpottComment #4
dawehnerNice refactoring, well and bugfix :)
I'm wondering whether it would be useful to check whether Drupal is installed instead.
Comment #5
alexpottRe #4 - i don't think so. The next thing that happens is \Drupal\FunctionalTests\Installer\InstallerTestBase::visitInstaller() - we could add a default assertion to that method in a follow-up if we like. But if the installer ain't working InstallerTestBase tests have the habit of breaking very hard :)
Comment #7
alexpottDrupalCI blip
Comment #10
larowlanCommitted 82d29a6 and pushed to 8.7.x. Thanks!
c/p as e0ca4dcc3b and pushed to 8.6
Comment #12
hchonovThis commit breaks functional JS tests if XDEBUG_CONFIG is defined as an env variable - #3019706: Functional JS Tests are broken if XDEBUG_CONFIG is set as an env variable.