Problem/Motivation

Debugging requests made to the installer pages in InstallerTestBase does not work because the xdebug cookies are not set up.

Proposed resolution

Fix it by moving the cookie setting into initMink

Test instructions

  • enable xdebug
  • set a breakpoint in install_begin_request
  • run core/tests/Drupal/FunctionalTests/Installer/MinimalInstallerTest.php

Remaining tasks

User interface changes

None

API changes

None

Data model changes

None

CommentFileSizeAuthor
#2 3002279-2.patch3.87 KBalexpott
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

alexpott created an issue. See original summary.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented
Status: Active » Needs review
FileSize
3002279-2.patch3.87 KB

We should also take this opportunity to make it simpler to keep UpgradePathTestBase InstallTestBase and BrowserTestBase tests all in sync.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented
Issue summary: View changes
dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner at Chapter Three commented
Status: Needs review » Reviewed & tested by the community

Nice refactoring, well and bugfix :)

+++ b/core/tests/Drupal/FunctionalTests/Update/UpdatePathTestBase.php
@@ -244,37 +232,8 @@ protected function doInstall() {
+  protected function initFrontPage() {
+    // Do nothing as Drupal is not installed yet.
   }

I'm wondering whether it would be useful to check whether Drupal is installed instead.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented

Re #4 - i don't think so. The next thing that happens is \Drupal\FunctionalTests\Installer\InstallerTestBase::visitInstaller() - we could add a default assertion to that method in a follow-up if we like. But if the installer ain't working InstallerTestBase tests have the habit of breaking very hard :)

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 2: 3002279-2.patch, failed testing. View results

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented
Status: Needs work » Reviewed & tested by the community

DrupalCI blip

  • larowlan committed 82d29a6 on 8.7.x 
    Issue #3002279 by alexpott: Xdebug in InstallerTestBase

  • larowlan committed e0ca4dc on 8.6.x 
    Issue #3002279 by alexpott: Xdebug in InstallerTestBase

(cherry picked...
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan as a volunteer and at PreviousNext commented
Status: Reviewed & tested by the community » Fixed

Committed 82d29a6 and pushed to 8.7.x. Thanks!

c/p as e0ca4dcc3b and pushed to 8.6

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

hchonov’s picture

hchonov
Primary language Bulgarian
Location 🇪🇺🇩🇪🇧🇬
CreditAttribution: hchonov at bio.logis Genetic Information Management GmbH commented

This commit breaks functional JS tests if XDEBUG_CONFIG is defined as an env variable - #3019706: Functional JS Tests are broken if XDEBUG_CONFIG is set as an env variable.