This patch makes it possible to alter the value of a possible submission component value when being submitted.

CommentFileSizeAuthor
#4 interdiff-2-4.txt1.98 KBpaulvandenburg
#4 webform-textfield_to_uppercase_option-3002260-4.patch2.04 KBpaulvandenburg
#2 add-uppercase-option-to-textfield-component-3002260-2.patch1.62 KBruudvanoijen

Comments

ruudvanoijen created an issue. See original summary.

ruudvanoijen’s picture

ruudvanoijen commented
Status: Active » Needs review
StatusFileSize
new add-uppercase-option-to-textfield-component-3002260-2.patch1.62 KB

The patch

Status: Needs review » Needs work

The last submitted patch, 2: add-uppercase-option-to-textfield-component-3002260-2.patch, failed testing. View results

paulvandenburg’s picture

paulvandenburg commented
Status: Needs work » Needs review
StatusFileSize
new webform-textfield_to_uppercase_option-3002260-4.patch2.04 KB
new interdiff-2-4.txt1.98 KB

I don't know why that patch failed, the test results all seem to have passed?

However I did find some stuff that could be better.
- The hook pre save is not the best place to perform the conversion.
Instead use a value_callback on the element so the converted value is converted everywhere, both on the preview page as well as navigating back and forth on a multi page form.
- I think the message for the new checkbox could be more clear.

I've made the mentioned modifications in this patch.

Status: Needs review » Needs work

The last submitted patch, 4: webform-textfield_to_uppercase_option-3002260-4.patch, failed testing. View results

tvoesenek’s picture

tvoesenek commented
Status: Needs work » Reviewed & tested by the community

Patch works as described.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Status: Reviewed & tested by the community » Needs work

Thanks for the patch.

In webform_textfield_uppercase_value(), $input should not have a default value because it is followed by a parameter that does not have one. The new feature needs a test. Please run a coding standards check on the patch.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Status: Needs work » Closed (outdated)

Drupal 7 is no longer supported. If this applies to a supported version, please re-open.

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.