Apply new {project}:{module} format for dependencies in info.yml filehttps://www.drupal.org/docs/8/creating-custom-modules/let-drupal-8-know-about-your-module-with-an-infoyml-file

It is supported since 8.0 and 7.40 Change Record: Project namespaces can now be added for module dependencies, and is now a Best Practice Define project dependencies in core module .info files).

It will be useful to install/update via composer. So sooner is better.


Hope this helps.

CommentFileSizeAuthor
#5 Update_dependencies_format_in_info.yml_3002171-5.patch1.44 KBchipway
#2 Update_dependencies_format_in_info.yml-3002171-1.patch454 bytesomrmankar
Screenshot_2018-09-25 https git drupal org project message_subscribe git 8 x-1 x.png22.35 KBomrmankar

Comments

omrmankar created an issue. See original summary.

omrmankar’s picture

omrmankar
Primary language English
Location Pune, Maharashtra
commented
StatusFileSize
new Update_dependencies_format_in_info.yml-3002171-1.patch454 bytes

Here is the patch. Please review.

omrmankar’s picture

omrmankar
Primary language English
Location Pune, Maharashtra
commented
Priority: Major » Normal
alonaoneill’s picture

alonaoneill commented

Reviewed the patch for spelling and grammar. Formatting aligns to Drupal documentation standards. Everything looks good, but 

+++ b/message_subscribe.info.yml
@@ -3,9 +3,9 @@ description: 'Subscribe API for the Message and Message notify modules.'
   - og

Should be og:og

Marking as Need work.
Thank you for working on module!

chipway’s picture

chipway commented
StatusFileSize
new Update_dependencies_format_in_info.yml_3002171-5.patch1.44 KB

All dependencies must be prefixed by project name, So I added missing ones.
Please review.

chipway’s picture

chipway commented
Status: Needs work » Needs review
sean_e_dietrich’s picture

sean_e_dietrich
he/him
Primary language English
Location Sacramento, CA
commented
Status: Needs review » Reviewed & tested by the community

Patch #5 applies successfully. Marking as RTBC.

  • jhedstrom committed 80e1025 on 8.x-1.x authored by chipway 
    Issue #3002171 by omrmankar, chipway: Dependency namespacing in .info....
jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
commented
Status: Reviewed & tested by the community » Fixed

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.