Capitalize the name of the module, because module names are proper nouns.
Dependencies - A list of other modules your module depends on.
Dependencies should be namespaced in the format {project}:{module}, where {project} is the project name as it appears in the Drupal.org URL (e.g. drupal.org/project/views) and {module} is the module's machine name.

https://www.drupal.org/docs/7/creating-custom-modules/writing-module-inf...

CommentFileSizeAuthor
#5 3002043-5--clean_up_info_files.patch2.36 KBdrunken monkey
#5 3002043-5--clean_up_info_files--interdiff.txt1.75 KBdrunken monkey
#2 search_api-info-3002043-2.patch1.14 KBalonaoneill

Comments

alonaoneill created an issue. See original summary.

alonaoneill’s picture

alonaoneill commented
Assigned: alonaoneill » Unassigned
Status: Active » Needs review
StatusFileSize
new search_api-info-3002043-2.patch1.14 KB

I uploaded a patch that Capitalize the name of the module and dependency namespacing in the .info.yml file.
Thanks!

alonaoneill’s picture

alonaoneill commented
Issue summary: View changes
volkswagenchick’s picture

volkswagenchick
she/her
Primary language English
Location San Francisco Bay Area
commented
Status: Needs review » Reviewed & tested by the community

Patch applied using simplytest.me. Dependency namespacing is now aligned with drupal documentation standards. SInce this is a D7 module, I am not certain the name of the project must be capitalized, someone can weigh on this.

Marking RTBC

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new 3002043-5--clean_up_info_files--interdiff.txt1.75 KB
new 3002043-5--clean_up_info_files.patch2.36 KB

Thanks a lot for creating this issue!
I agree with both of these changes. Seems the project:module format has been supported by Drupal 7 for three years now – that should be plenty to rely on it. (Especially with the security releases in between, of course.)

However, Views is not in Drupal Core in D7, so it should be views:views. Also, the change should also be made to search_api.info itself – and, while we’re at it, to the two test modules, for consistency’s sake.
Revised patch attached, please test/review!

alonaoneill’s picture

alonaoneill commented
Status: Needs review » Reviewed & tested by the community

Looks good to me. Patch applied.
Marking RTBC
Thanks

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Reviewed & tested by the community » Fixed

Alright, thanks a lot for testing/reviewing!
Committed.
Thanks again!

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.