Hi,

All dependencies must be prefixed by project name, But some are wrong. So correct them.

CommentFileSizeAuthor
#2 Update_dependencies_format_in_info.yml_3001781-2.patch1.26 KBchipway

Comments

chipway created an issue. See original summary.

chipway’s picture

chipway commented
Assigned: chipway » Unassigned
Status: Needs work » Needs review
StatusFileSize
new Update_dependencies_format_in_info.yml_3001781-2.patch1.26 KB

Most were right. Here is the patch the few wrong ones. Please review.

Status: Needs review » Needs work

The last submitted patch, 2: Update_dependencies_format_in_info.yml_3001781-2.patch, failed testing. View results

chipway’s picture

chipway commented
Status: Needs work » Needs review

Unrelated test failure. Please review manually.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

@chipaway

+++ b/tests/modules/config_selector_profile_test/config_selector_profile_test.info.yml
@@ -3,6 +3,6 @@ type: profile
-  - config_test
-  - config_selector
-  - config_selector_test_provides_multiple
+  - drupal:config_test
+  - config_selector:config_selector
+  - config_selector:config_selector_test_provides_multiple

Support for these types of dependencies in install profiles is super recent. This landed in #2855026: Installation profiles do not support project:module format for dependencies - and was not available two months ago :) The test fail was definitely related!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Needs review » Fixed

Anyhow all looks good now we support such dependencies in install profiles.

  • alexpott committed 6657e86 on 8.x-1.x authored by chipway 
    Issue #3001781 by chipway: Wrong Dependency prefix
chipway’s picture

chipway commented

Thanks for details on tests and commit Alex.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.