Umami green link text fails WCAG contrast on peach background.

This is important for backgrounds with CSS gradients & images.

I tested the pages for a11y issues (color contrast) using Firefox Nightly.
After 8.7.x already includes the darker background to hero text, the only 1 issue I found was the contrast Home link in the breadcrumbs.

More infio please. Which text is it? What contrast does it report? the issue summary doesn't say. I'm reviewing this on a phone and I can't make out what's in the screenshot.

In /articles and /recipes pages,
Below the Umami logo there are breadcrumb links.
It also sits on top of background-color: #fbf5ee.

The Home link in the breadcrumbs has

color: #00836d /* rgb(0, 131, 109) */
font-size: 16px

Firefox A11y inspector shows Contrast: 4.34 with an exclamation mark.

Here's a close-up of the screenshot:

Good catch. I think this slipped past us on other accessibility reviews. This foreground/background combination isn't used in many places.

#00836d text against white background - contrast 4.7:1 - pass.
#00836d text against #fbf5ee background - contrast 4.34:1 - fail.

So let's review where else the latter combination is seen:

• breadcrumb text
• "search help" link text on /search/node
• Anywhere else...?

Note the contact form buttons use the green as a background colour, on a #fbf5ee page background. (This is fine, the ratio required for WCAG Non-text contrast is 3:1)

To fix this, it can be darkened. An good way to do this is to treat it as a HSV, and change the V component only.

Before:
#00836d - hsv(169,255,131)

After:
#008068 - hsv(169,255,128) - same hue and saturation

#008068 on #fbf5ee has contrast 4.52:1

I think we can change this colour everywhere it is used.

I created a patch that change the colour #00836d to #008068.
It affects 3 CSS files, and 4 SVG icons.

Here's the result of Firefox Nightly a11y contrast testing tool (4.52:1 - passed!)

Clearer title, better for the commit log.

I dunno what we call this colour. Peach, salmon, or whatever.

Will review patch when I'm on a big computer.

Good stuff, no instances of the old colour left. RTBC, assuming the designer/maintainer are OK with it.

This is how little difference it makes to keep the WCAG threshold gods happy: https://contrast-ratio.com/#%23008068-on-%2300836d

The test failure is unrelatrd to the changes in the patch. Lots of CSS patches are running into this bug in our test framework. #2990645: "Build Successful" is treated as a test failure.

From the design perspective, this looks good to me and is slight enough to make little difference to the design.

Thank you for the confirmation @kjay! Committed d4fa72e and pushed to 8.7.x. Thanks!

fixing accessibility tag