Add recipe for Vegan Milk Chocolate to Umami

Working on this as part of distributed sprint NWDUG

Add vegan chocolate recipe to umami.

Needs review

Updated image filename to be inline with issue 2939908.

LGTM :-)

I'll create a patch for the mentioned changes.

Created patch with suggested changes from Eli-T in comment #8.
In summary, the changes include:

• Title casing
• Removed ingredients from instruction field
• Removed unnecessary steps
• Added serial commas

Thanks @Eli-T for the comment. As I looked through the other recipes, I realized that we usually use measurements in "g" an "ml" instead of "cups". As I am based in Europe, this is also more familiar for me. What is the general consents here? Should we translate everyhting to metric measurements?

I'll provide a patch shortly.

Patch created with source from comment #10. Changed spelled out numbers to fractions as suggested in comment #11 and #15.

1. +++ b/core/profiles/demo_umami/modules/demo_umami_content/default_content/LICENCE.txt
   @@ -9,10 +9,10 @@ heritage-carrots.jpg by Keith Jay
   -pineapple-placeholder-10.jpg by Keith Jay
   

   Unrelated change

2. +++ b/core/profiles/demo_umami/modules/demo_umami_content/default_content/recipe_instructions/vegan-milk-chocolate.html
   @@ -0,0 +1,9 @@
   +    <li>Form the paste into balls, bars, or whatever shape you want.</li>
   

   It feels like "whatever shape you want" is a bit too informal for this context. How about "or any shape you want"?

Removed unrelated change and altered text to @lauriii's suggestion.

Edit: path does not apply due to binary file issues

badcamp 2018

Patch #22 looks good and addresses the changes proposed by @laurii in comment #20-21.

I get two warnings:

git apply -v umami-vegan-milk-chocolate-recipe-3001610-22.patch
umami-vegan-milk-chocolate-recipe-3001610-22.patch:86: trailing whitespace.
▒9▒▒▒p▒r▒T▒▒$▒▒n▒▒▒]Z▒▒.▒▒▒▒Nz!▒N▒B
                 H▒▒5#▒"▒Z▒2▒62▒▒Y▒▒ʆaxR▒I▒▒6▒▒窱-*▒▒   ▒▒|M▒
umami-vegan-milk-chocolate-recipe-3001610-22.patch:236: trailing whitespace.
▒▒▒▒i▒

In my opinion those are fine and are due to the binary jpg in the patch.

Tested this and looks great, however I noticed that the HTML file names have an -umami suffix and it seems that normally HTML and the related JPG files have the same name.

Let's quickly fix these inconsistencies and the one mentioned in #26 and get this in :)

Fixed the inconsistencies in the patch.

#27 was not addressed.

Btw, also the LICENSE.TXT file needs to be updated when renaming JPGs.

• Added suffix "-umami" to file names of JPG and HTML files as suggested in comment #27
• Changed License file accordingly as suggested in comment #30

Forgot to rename one file link which is fixed now.

The patch was corrupt and I needed to update it.

Re run test, looks good.

The (re)test dispatcher contains the following errors:

error: core/profiles/demo_umami/modules/demo_umami_content/default_content/images/vegan-chocolate-umami.jpg: No such file or directory
error: core/profiles/demo_umami/modules/demo_umami_content/default_content/recipe_instructions/vegan-milk-chocolate-umami.html: No such file or directory
16:36:35 Patch Error
16:36:35 The patch attempt returned an error.  Error code: 1
16:36:35 Patch Failed to Apply

This is due to the patch being incorrect. Instead of adding the files:
--- /dev/null
+++ b/core/profiles/demo_umami/.../vegan-chocolate-umami.jpg

The patch attempts to alter the non-existing files. Could you upload a patch where the files are added instead of altered?

I fixed the existing issue from my last commits 31, 35. Sorry for the long time I needed to upload a new version and my beginner mistakes ;-) I hope everything works now and all open tasks from #27 and #30 and #39 are resolved.

Added interdiff between #29 and #41.

Testing at The University of Edinburgh D8 Contribution Day #uoe-d8-contribution

I have tested patch #41 and there was a file name inconsistency between the .jpg and the .html files. So, created a new patch and everything looks to be fine. Only caveat is that the interdiff between #41 and #44 seems larger than previously. Just to note, this is my first ever Drupal contribution so please be gentle.

I've been mentoring @stratosf1 at the University of Edinburgh #uoe-d8-contribution. I've tested his patch on a clean installation of 8.7.x and the new recipe looks good (screenshots attached).

The file names for jpg & html are matching for me - vegan-milk-chocolate-umami.html and vegan-milk-chocolate-umami.jpg.

I believe patch #44 resolves all the issues mentioned in the last comments (License.txt has been altered (#30), -umami suffix has been added (#27), additional indentation has been removed (#26)). The tests have passed as well and @mairi has manually tested the patch on a clean installation, so I'm switching this issue to Reviewed en tested.

For now, we need to need to discuss whether we should create a change record to describe the changes that were made.

Well, there's actually no necessity to add a change record. I prefer at least thinking about it in the discussion since there was a change record for the initial addition of the demo_umami profile.

The patch mostly adds files and only alters LICENSE.txt and recipes.csv, so it might not actually impact anyone. In this case, it should probably be fine to not have a change record. Do you agree? (I'll remove the tag for now)

This uses the same image as #2939908: Add an article to Umami - Dairy-free chocolate did which has now landed. Which on one hand is great because we have a media re-use case in Umami! So once the media library lands moving to it seems like a great idea. On the other it does mean we're adding two images completely the same :(

Also all the other recipes have an image from making the recipe. Is that the case here? If so kudos to making the wrappers!

We need a reroll and a decision on the image.

I also suspect that the current image name - vegan-milk-chocolate-umami is claiming to be a photo of the recipe on the umami site so it is not that that needs looking into.

Patch rerolled to update the work on this case.

Comment #54 leads me to think that this is now outdated. Is it?

There has been no work here for 6 years, or a response to the query in the last comment to confirm the need for this issue.

If there is work to do here, then either re-open the issue or open a new issue and reference this one. If the choice is to use this issue then add a comment change make sure to change the issue status to 'Active'.