There are some dead code paths left after the introduction of include resolution outside the normalization system.

Let's clean those up.

CommentFileSizeAuthor
#7 3001564-7.patch5.17 KBgabesullice
#7 interdiff.txt1.18 KBgabesullice
#2 3001564-2.patch4.46 KBgabesullice

Comments

gabesullice created an issue. See original summary.

gabesullice’s picture

gabesullice
Primary language English
commented
Status: Active » Needs review
StatusFileSize
new 3001564-2.patch4.46 KB

Here it is.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs review » Reviewed & tested by the community

😲 🤘 🎉

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Title: Followup to #2997600: Clean up dead code paths » Follow-up to #2997600: Clean up dead code paths

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 2: 3001564-2.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Issue tags: +Needs reroll

Just needs a reroll to fix CS violations!

gabesullice’s picture

gabesullice
Primary language English
commented
Status: Needs work » Reviewed & tested by the community
StatusFileSize
new interdiff.txt1.18 KB
new 3001564-7.patch5.17 KB

Unfortunately, this is gonna fail from deprecation notices.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 7: 3001564-7.patch, failed testing. View results

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Related issues: +#3001958: 4 test fails due to using deprecated code on 8.6 and 8.7 since #2996789: temporarily fork the test trait, +#2996789: Deprecate Drupal\field\Tests\EntityReference\EntityReferenceTestTrait

Working to get those 4 failures due to #2996789: Deprecate Drupal\field\Tests\EntityReference\EntityReferenceTestTrait resolved in #3001958: 4 test fails due to using deprecated code on 8.6 and 8.7 since #2996789: temporarily fork the test trait.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

#3001958: 4 test fails due to using deprecated code on 8.6 and 8.7 since #2996789: temporarily fork the test trait landed, retesting.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs work » Reviewed & tested by the community

  • Wim Leers committed c75de09 on 8.x-2.x authored by gabesullice 
    Issue #3001564 by gabesullice, Wim Leers: Follow-up to #2997600: Clean...
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Reviewed & tested by the community » Fixed
Issue tags: -Needs reroll

🎉

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.