In the More Like This contextual filter, we unset the parent break_phrase and not options since they don’t apply to that filter. However, we don’t go about it properly, causing the following notice when displaying its options form:

Notice: Undefined index: break_phrase in options_form() (line 96 of …/sites/all/modules/search_api/contrib/search_api_views/includes/handler_argument.inc).

CommentFileSizeAuthor
#2 3001424-2--mlt_filter_parent_options.patch1.41 KBdrunken monkey

Comments

drunken monkey created an issue. See original summary.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Active » Needs review
StatusFileSize
new 3001424-2--mlt_filter_parent_options.patch1.41 KB

This should fix it (and a tiny problem in the parent option definition).

drilauri’s picture

drilauri commented

Sweet! Patch worked for me. Thanks!!

  • drunken monkey committed 9ef4235 on 7.x-1.x 
    Issue #3001424 by drunken monkey: Fixed notice when configuring the More...
drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Title: More Like This contextual fitler doesn’t handle parent options correctly » More Like This contextual filter doesn’t handle parent options correctly
Status: Needs review » Fixed

Great to hear, thanks a lot for testing and reporting back!
Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.