CommentFileSizeAuthor
#10 eu_cookie_compliance-coding-standard-3001177-9-7.x.diff10.91 KBsvenryen
#9 eu_cookie_compliance-coding-standard-3001177-8-7.x.patch9.12 KBsvenryen
#3 3001177-coding-standard-2.patch1.29 KBdeepanker_bhalla
#2 Screen Shot 2018-09-20 at 14.36.31.png148.33 KBvdenis
Screen Shot 2018-09-20 at 14.21.41.png57.5 KBvdenis

Comments

denisveg created an issue. See original summary.

vdenis’s picture

vdenis commented
Issue summary: View changes
StatusFileSize
new Screen Shot 2018-09-20 at 14.36.31.png148.33 KB
deepanker_bhalla’s picture

deepanker_bhalla commented
Status: Active » Needs work
StatusFileSize
new 3001177-coding-standard-2.patch1.29 KB

Fixed some of the coding standard issues.

msankhala’s picture

msankhala commented
Status: Needs work » Reviewed & tested by the community

@deepanker_bhalla Good work. I can confirm the patch #3 is applying cleanly and fixing all the coding standard reported by the PHPCS. Here is the output:

❯ eu-cookie-compliance 8.x-1.x* git apply -v 3001177-coding-standard-2_0.patch
Checking patch eu_cookie_compliance.module...
Checking patch src/Plugin/ConsentStorage/BasicConsentStorage.php...
Applied patch eu_cookie_compliance.module cleanly.
Applied patch src/Plugin/ConsentStorage/BasicConsentStorage.php cleanly.

❯ eu-cookie-compliance 8.x-1.x* phpcs --standard=Drupal .

❯ eu-cookie-compliance 8.x-1.x*

PHPCS is reporting no coding standard warning after applying the patch #3.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 3: 3001177-coding-standard-2.patch, failed testing. View results

msankhala’s picture

msankhala commented
Status: Needs work » Reviewed & tested by the community

Its a test bot hickup. The build was successful.

svenryen’s picture

svenryen commented

Thanks for the patch. Would anybody be interested in doing a similar job for D7?

svenryen’s picture

svenryen commented
StatusFileSize
new eu_cookie_compliance-coding-standard-3001177-8-7.x.patch9.12 KB

Drupal 7 patch

svenryen’s picture

svenryen commented
StatusFileSize
new eu_cookie_compliance-coding-standard-3001177-9-7.x.diff10.91 KB

Updated patch, since array type hints are available in PHP5.

  • svenryen committed e535c77 on 7.x-1.x 
    Issue #3001177 by svenryen, deepanker_bhalla, denisveg: Coding standard
svenryen’s picture

svenryen commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.