After exploring the demo_umami profile (and reading documentation about the things I was wondering about) I see that the umami.libaries.yml are well organized, but slightly off standard.

According to https://www.drupal.org/docs/develop/standards/css/css-file-organization-... there should be base: component: and layout: categories.

I've included a patch

CommentFileSizeAuthor
#4 umami_basecss_after.png865.12 KBmcannon
#4 umami_basecss_before.png852.44 KBmcannon
umami-follow-css-file-organization.patch580 bytesparijke

Comments

parijke created an issue. See original summary.

imalabya’s picture

imalabya
Primary language English
Location Bangalore
commented
Status: Active » Needs review
eli-t’s picture

eli-t
he/him
Primary language English
Location Manchester
commented
Issue tags: +DistributedSprintUK18
mcannon’s picture

mcannon commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new umami_basecss_before.png852.44 KB
new umami_basecss_after.png865.12 KB

I tested the patch and it works as intended without issue. I also verified that any styles in base.css were not overriding any styles in layout css folder those are the only theme files that rendered before the base.css file. I found no conflict nor saw any visible issues.

Markup before patch:
Markup before patch

Markup after patch:
Markup after patch

  • lauriii committed b3047e1 on 8.7.x 
    Issue #3001164 by parijke, mcannon: To follow standards base.css should...

  • lauriii committed debf2c7 on 8.6.x 
    Issue #3001164 by parijke, mcannon: To follow standards base.css should...
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Reviewed & tested by the community » Fixed

Committed b3047e1 and pushed to 8.7.x. Also cherry picked to 8.6.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.