FILE: ...matter/src/Plugin/Field/FieldFormatter/ContactFieldFormatter.php
----------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 2 LINES
----------------------------------------------------------------------
  34 | ERROR | [ ] Parameter $view_mode is not described in comment
  34 | ERROR | [ ] Parameter $third_party_settings is not described
     |       |     in comment
 110 | ERROR | [x] Short array syntax must be used to define arrays
----------------------------------------------------------------------
CommentFileSizeAuthor
#2 3001152-coding-standard-2.patch1.22 KBdeepanker_bhalla

Comments

deepanker_bhalla created an issue. See original summary.

deepanker_bhalla’s picture

deepanker_bhalla commented
Status: Needs work » Needs review
StatusFileSize
new 3001152-coding-standard-2.patch1.22 KB

Fixed the coding standard issues.

msankhala’s picture

msankhala commented
Status: Needs review » Reviewed & tested by the community

@deepanker_bhalla Good work. I can confirm the patch #2 is applying cleanly and fixing all the coding standard reported by the PHPCS. Here is the output:

❯ contact_formatter 8.x-1.x* git apply -v 3001152-coding-standard-2.patch
Checking patch src/Plugin/Field/FieldFormatter/ContactFieldFormatter.php...
Applied patch src/Plugin/Field/FieldFormatter/ContactFieldFormatter.php cleanly.

❯ contact_formatter 8.x-1.x* phpcs --standard=Drupal .

❯ contact_formatter 8.x-1.x*

PHPCS is reporting no coding standard warning after applying the patch #2.

chris matthews’s picture

chris matthews commented

Would it be possible to commit this patch to 8.x-1.x-dev and tag a 8.x-1.1 release? Or, would it be better to wait until Issue #3017452: Personal Contact Form is resolved?

albertski’s picture

albertski commented
Status: Reviewed & tested by the community » Fixed

Thanks. I pushed to dev. Will create a release when #3017452: Personal Contact Form is resolved.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.