Frontpage with query parameter results in "Page not found"

@axel.rutz Yeah patch works, Just a thought what if fragment added then this patch not works.

Here is a test for this fix.

Here is a patch with fix and test from #6 and #7 including minor fix.

+      $components = parse_url($path);
+      $query = $request->query->all();
+      // Remove querystring and fragment.
+      $path = $components['path'];
+      // Merge frontpae query to URL query, so actual URL takes precedence..
+      if (!empty($components['query'])) {
+        parse_str($components['query'], $parameters);
+        array_replace($parameters, $request->query->all());
+        $request->query->replace($parameters);
+      }

1. Looks like $query = $request->query->all(); is not used
2. "// Merge frontpae query to URL query, so actual URL takes precedence.." - grammatical errors

@goodboy Thanks for the review. Here is the updated patch.

Thanks @goodboy for the review.
Thanks @msankhala for the patch, I tested it out your patch applies cleanly and works well just correcting the minor grammatical error and uploading the new patch along with interdiff

This new patch is making the comment to exceed 80 characters.

Thanks @msankhala for noticing that, this reminds me to notice coding standard errors in 'PathProcessorFrontTest.php' as well.
Correcting both and uploading the new patch.

This looks great and has test-coverage. RTBC.

+++ b/core/lib/Drupal/Core/PathProcessor/PathProcessorFront.php
@@ -42,6 +42,16 @@ public function processInbound($path, Request $request) {
+      $path = $components['path'];
+      // Merge frontpage query to URL query, so that actual URL takes
+      // precedence.
+      if (!empty($components['query'])) {
+        parse_str($components['query'], $parameters);
+        array_replace($parameters, $request->query->all());
+        $request->query->replace($parameters);
+      }
     }

I'm not entirely sure why we need to merge the query parameters, and 'merge frontpage query to URL query' isn't grammatically correct - it should be 'with' instead of 'to', but what is the front page query?

Change this comment as I understood.

#18 addressed #16

OK that's much better.

Committed 920eb06 and pushed to 8.7.x. Thanks!