Closed (fixed)
Project:
Drupal core
Version:
8.6.x-dev
Component:
media system
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
17 Sep 2018 at 23:02 UTC
Updated:
10 Oct 2018 at 09:44 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
acbramley commentedComment #3
acbramley commentedComment #4
acbramley commentedComment #6
sam152 commentedComment #7
sam152 commentedLooks good to me, the interface of
LoggerChannelInterfacesays:So I can't see any issues with changing this. Will see what the testbot says. Not exactly sure if testing this makes sense, I suppose we could use a different logger in the oembed tests, but haven't seen any examples of that done elsewhere.
Comment #8
dawehnerI am wondering whether something like this could be automatically checked.
Comment #9
dawehnerOtherwise, totally +1
Comment #10
alexpottI think best thing to do will be to add a follow-up task to mark the LoggerChannelInterface @internal. So at least IDEs will help us. This task should also replace other incorrect typehints.
Also how does this break the monolog module? I don't think this is true since #2749859: Logger channel factory must return instances of LoggerChannelInterface.
But there is no harm in obeying the instructions not to use it that exist on the interface. As an API widening (not change) I don't think this needs tests.
Committed and pushed e6a096cf45 to 8.7.x and faf551f882 to 8.6.x. Thanks!