Dependencies must be prefixed by project name.

Already done for main module, but not for sub-modules.

It will be useful to install/update via composer. So sooner is better.
Hope this helps.

Comments

chipway created an issue. See original summary.

chipway’s picture

Assigned: chipway » Unassigned
Status: Needs work » Needs review
StatusFileSize
new381 bytes

Here is the patch. Please review.

riddhi.addweb’s picture

Status: Needs review » Reviewed & tested by the community
StatusFileSize
new39.8 KB

@chipway, I checked your patch as per the standards that mentioned in pareview.sh & I also attached the screenshot for the same.

Thanks!..

  • itamair committed 45ab65f on 8.x-1.x authored by chipway
    Issue #3000027 by chipway, riddhi.addweb: Improve Dependencies for...
itamair’s picture

Status: Reviewed & tested by the community » Fixed

thanks @chipway ... I added to your patch also the dependency fix of the main leaflet module from geofield:

dependencies:
  - geofield:geofield

and just committed to dev

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.