Apply new {project}:{module} format for dependencies in info.yml https://www.drupal.org/docs/8/creating-custom-modules/let-drupal-8-know-about-your-module-with-an-infoyml-file
It is supported since 8.0 and 7.40 Change Record: Project namespaces can now be added for module dependencies, and is now a Best Practice Define project dependencies in core module .info files).
It will be useful to use composer. So sooner is better.
Hope this helps.

CommentFileSizeAuthor
#2 Update_dependencies_format_in_info.yml_2999913-2.patch1.54 KBchipway

Comments

chipway created an issue. See original summary.

chipway’s picture

chipway commented
Assigned: chipway » Unassigned
Status: Needs work » Needs review
StatusFileSize
new Update_dependencies_format_in_info.yml_2999913-2.patch1.54 KB

Here is a patch that extends coverage to sub-modules. Please review.

alonaoneill’s picture

alonaoneill commented
Status: Needs review » Reviewed & tested by the community

Code looks good. The dependency namespacing aligns with Drupal documentation standards.
Patch applied via simplytest.me
Marking as RTBC
Thank you for working on module!

  • MiSc committed 5d952e4 on 8.x-1.x authored by chipway 
    Issue #2999913 by chipway: Update Dependencies to new Format in .info....
misc’s picture

misc commented

Thanks! And sorry for the late response. This would be in next release.

misc’s picture

misc commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

tobybellwood’s picture

tobybellwood commented

This commit unfortunately has introduced the incorrect namespaces for the dependencies project:module

To resolve correctly they should be varnish_purge:varnish_purge (no r) - this will impact any module that requires one of the submodules explicity (ie. drupal.org/project/lagoon_varnish) as they will be unable to resolve the incorrect project:module combo.

I will create a new issue and patch.

[EDIT] - looked at https://www.drupal.org/project/varnish_purge/issues/2845054 and it looks like fixing this will break half the userbase (non-composer maybe).

Can a completely new 8.x-3.x branch be cut with a single naming strategy?