Capitalize the name of the module, because module names are proper nouns.
Also according to Drupal standards, modules should include dependencies in the .info.yml file.
Dependencies should be namespaced in the format {project}:{module}, where {project} is the project name as it appears in the Drupal.org URL (e.g. drupal.org/project/views) and {module} is the module's machine name.
https://www.drupal.org/docs/8/creating-custom-modules/let-drupal-8-know-...
Patch to follow, thanks!

Comments

alonaoneill created an issue. See original summary.

alonaoneill’s picture

Assigned: alonaoneill » Unassigned
Status: Active » Needs review
StatusFileSize
new601 bytes

I uploaded a patch that Capitalize the name of the module and dependency namespacing in the .info.yml file.
Thanks!

volkswagenchick’s picture

Status: Needs review » Reviewed & tested by the community

Code looks good. The core modules and the contrib modules are have the correct namespacing. Patch applied via simplytest.me

Marking RTBC

  • Loparev committed 419be47 on 8.x-2.x authored by alonaoneill
    Issue #2999126 by alonaoneill: Dependency namespacing in .info.yml file
    
loparev’s picture

Thanks

loparev’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.