Currently there is a bug in xmlsitemap version 2.5. When updating the sitemap using drush you get the following warning:
Use of undefined constant XMLSITEMAP_BATCH_LIMIT - assumed 'XMLSITEMAP_BATCH_LIMIT' (this will throw an Error in a future version of PHP) xmlsitemap.drush.inc:33

There is already a fixed issue for xmlsitemap: #2996092: Use of undefined constant XMLSITEMAP_BATCH_LIMIT

We should include the used patch as well:
#2996092-7: Use of undefined constant XMLSITEMAP_BATCH_LIMIT

CommentFileSizeAuthor
#8 dvg-update_xmlsitemap_for_undefined_constant_fix-2998977-8.patch535 bytesjoshahubbers
#4 dvg-update_xmlsitemap_for_undefined_constant_fix-2998977-4.patch522 bytespaulvandenburg
#2 dvg-fix_xmlsitemap_undefined_constant-2998977-2.patch628 bytespaulvandenburg

Comments

paulvandenburg created an issue. See original summary.

paulvandenburg’s picture

paulvandenburg commented
Status: Active » Needs review
StatusFileSize
new dvg-fix_xmlsitemap_undefined_constant-2998977-2.patch628 bytes

This patch adds the xmlsitemap patch.

paulvandenburg’s picture

paulvandenburg commented

We could also just update to xmlsitemap version 2.6 as that contains the mentioned patch.

paulvandenburg’s picture

paulvandenburg commented
StatusFileSize
new dvg-update_xmlsitemap_for_undefined_constant_fix-2998977-4.patch522 bytes

Update xmlsitemap to 2.6 instead, which contains the fix.

paulvandenburg’s picture

paulvandenburg commented
joshahubbers’s picture

joshahubbers commented
Status: Needs review » Reviewed & tested by the community
joshahubbers’s picture

joshahubbers commented
Status: Reviewed & tested by the community » Needs review
joshahubbers’s picture

joshahubbers commented
StatusFileSize
new dvg-update_xmlsitemap_for_undefined_constant_fix-2998977-8.patch535 bytes

Rerolled for current dev

paulvandenburg’s picture

paulvandenburg commented
Status: Needs review » Reviewed & tested by the community

Patch has been in use for a while, looks good.

  • paulvandenburg committed 83aa17c on 7.x-1.x 
    Issue #2998977 by paulvandenburg, JoshaHubbers: Patch xmlsitemap for...
paulvandenburg’s picture

paulvandenburg commented
Status: Reviewed & tested by the community » Fixed
paulvandenburg’s picture

paulvandenburg commented
Issue summary: View changes

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.