Problem/Motivation

entity title's maxlength is 255 and the embed_entity's entity_id field has default of 128.

Proposed resolution

Increase the max length to 255. Though it wouldn't cover all cases (e.g. A title with 255 characters + "(" character + length of node id: max length of 10 digits + ")" character), covers most of the cases.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#3 2998864-3.patch630 bytesvijaycs85
Screen Shot 2018-09-11 at 19.50.30.png75.19 KBvijaycs85
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

vijaycs85 created an issue. See original summary.

vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 as a volunteer and at Lullabot, Solathat commented
Issue summary: View changes
vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 as a volunteer and at Lullabot, Solathat commented
Status: Active » Needs review
FileSize
2998864-3.patch630 bytes

Status: Needs review » Needs work

The last submitted patch, 3: 2998864-3.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 as a volunteer and at Lullabot, Solathat commented
Issue summary: View changes
Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Title: Can't add entity with title greater than 126 characters » EntityEmbedDialog doesn't allow selecting entities with long titles
Status: Needs work » Reviewed & tested by the community
Issue tags: +Media Initiative

The same test failures are happening to entity_embed HEAD. This is ready.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed. Thanks!

vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 as a volunteer and at Lullabot, Solathat commented

yay! thanks.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.