Comments

chipway created an issue. See original summary.

chipway’s picture

Assigned: chipway » Unassigned
Status: Needs work » Needs review
StatusFileSize
new354 bytes

Proposed patch.

akash.addweb’s picture

Status: Needs review » Reviewed & tested by the community
StatusFileSize
new19.1 KB

@chipway, Thanks for providing the patch, Your patch clears all the dependency errors that shown in Preview report. I follow the report that I attached below.

jeroent’s picture

Status: Reviewed & tested by the community » Needs work

This module is also missing a dependency on menu_link_content. We can probably add it here since we're updating the .info.yml file anyway.

mrinalini9’s picture

Assigned: Unassigned » mrinalini9
mrinalini9’s picture

Assigned: mrinalini9 » Unassigned
Status: Needs work » Needs review
StatusFileSize
new384 bytes
new184 bytes

Updated patch and added dependency on menu_link_content as mentioned in #4, please review.

jeroent’s picture

Status: Needs review » Reviewed & tested by the community
jeroent’s picture

  • JeroenT committed ece5a8f on 8.x-1.x authored by mrinalini9
    Issue #2998835 by mrinalini9, chipway, Ronak.addweb, JeroenT: Update...
jeroent’s picture

Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x-1.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.