The delimiter and no_headers fields can not be used on feed form as it is. Changing values of these fields has no effect on import and this changed values are not stored to correct place either.

CommentFileSizeAuthor
#9 interdiff-2998781-6-9.txt1.12 KBmegachriz
#9 feeds-csv-feed-form-2998781-9.patch14.22 KBmegachriz
#6 feeds-csv-feed-form-2998781-6.patch14.23 KBmegachriz
#6 feeds-csv-feed-form-2998781-6-tests-only.patch11.79 KBmegachriz
#4 2998781-4.patch2.44 KBmikran
#4 interdiff.txt922 bytesmikran
#2 2998781-2.patch1.54 KBmikran

Comments

mikran created an issue. See original summary.

mikran’s picture

mikran commented
Status: Active » Needs review
StatusFileSize
new 2998781-2.patch1.54 KB

here is a fix

Status: Needs review » Needs work

The last submitted patch, 2: 2998781-2.patch, failed testing. View results

mikran’s picture

mikran commented
Status: Needs work » Needs review
StatusFileSize
new interdiff.txt922 bytes
new 2998781-4.patch2.44 KB

unit test updated accordingly

megachriz’s picture

megachriz
Primary language Dutch
commented
Status: Needs review » Needs work
Issue tags: +Needs tests

Thanks for catching this bug!

I think it would be useful to have a functional test for the feed form.

megachriz’s picture

megachriz
Primary language Dutch
commented
Status: Needs work » Needs review
StatusFileSize
new feeds-csv-feed-form-2998781-6-tests-only.patch11.79 KB
new feeds-csv-feed-form-2998781-6.patch14.23 KB

Here's a patch with a functional test.

The no_headers setting is not covered by the tests as that one probably will be removed in #3001863: CSV headers / No headers selection on the CSV Parser Form

The last submitted patch, 6: feeds-csv-feed-form-2998781-6-tests-only.patch, failed testing. View results

Status: Needs review » Needs work

The last submitted patch, 6: feeds-csv-feed-form-2998781-6.patch, failed testing. View results

megachriz’s picture

megachriz
Primary language Dutch
commented
Status: Needs work » Needs review
StatusFileSize
new feeds-csv-feed-form-2998781-9.patch14.22 KB
new interdiff-2998781-6-9.txt1.12 KB

Forgot to change the field name of the delimiter in the test. It changed from "plugin[parser][parser][delimiter]" to "plugin[parser][delimiter]". I also accidently turned off the test ::testImportSingleFile().

megachriz’s picture

megachriz
Primary language Dutch
commented
Issue tags: -Needs tests

  • MegaChriz committed d4faf8c on 8.x-3.x authored by mikran 
    Issue #2998781 by MegaChriz, mikran: Fixed saving settings for the feed...
megachriz’s picture

megachriz
Primary language Dutch
commented
Status: Needs review » Fixed

Committed #9.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.