FILE: ...olearn/modules/bootstrap_layouts/src/BootstrapLayoutsManager.php
----------------------------------------------------------------------
FOUND 5 ERRORS AFFECTING 5 LINES
----------------------------------------------------------------------
  17 | ERROR | [x] Doc comment short description must end with a full
     |       |     stop
  21 | ERROR | [ ] Missing short description in doc comment
  26 | ERROR | [ ] Missing short description in doc comment
 223 | ERROR | [ ] Description for the @return value is missing
 273 | ERROR | [x] Expected newline after closing brace
----------------------------------------------------------------------

and more...

CommentFileSizeAuthor
#8 2998722-coding-standard-7.patch991 bytesgangwarsurya
#6 2998722-coding-standard-6.patch12.78 KBdhirendra.mishra
#6 3-6_interdiff.txt1.23 KBdhirendra.mishra
#3 2998722-coding-standard-3.patch12.62 KBdeepanker_bhalla
#2 2998722-coding-standard-2.patch9.83 KBdeepanker_bhalla

Comments

deepanker_bhalla created an issue. See original summary.

deepanker_bhalla’s picture

deepanker_bhalla commented
Status: Needs work » Needs review
StatusFileSize
new 2998722-coding-standard-2.patch9.83 KB

Hi,

Fixed the coding standard issues.

deepanker_bhalla’s picture

deepanker_bhalla commented
StatusFileSize
new 2998722-coding-standard-3.patch12.62 KB

I have found some more issues while checking it with latest version. Thus updating the patch with all the issues resolved.

msankhala’s picture

msankhala commented
Status: Needs review » Needs work 
+++ b/README.md
@@ -1,6 +1,6 @@
-This project is the combination of the Drupal 7 [Display Suite Bootstrap Layouts]
+This project is combination of the Drupal 7[Display Suite Bootstrap Layouts]

It is a better option to break line instead of removing the "the" article to fit line into 80 characters. Like:

This project is the combination of the Drupal 7 [Display Suite Bootstrap 
Layouts] and [Panels Bootstrap Layouts] modules for Drupal 8.
+++ b/src/Plugin/BootstrapLayouts/BootstrapLayoutsUpdateInterface.php
@@ -28,8 +31,7 @@ interface BootstrapLayoutsUpdateInterface extends ContainerAwareInterface, Conta
+   *   the layout was processed successfully or not.   *.

Unnecessary *. at the end of line.

Rest looks good. I can confirm this patch #3 is fixing all the coding standard issue reported by PHPCS.

dhirendra.mishra’s picture

dhirendra.mishra commented
Assigned: Unassigned » dhirendra.mishra

working on it

dhirendra.mishra’s picture

dhirendra.mishra commented
Assigned: dhirendra.mishra » Unassigned
Status: Needs work » Needs review
StatusFileSize
new 3-6_interdiff.txt1.23 KB
new 2998722-coding-standard-6.patch12.78 KB

Correction from #4 comment.

msankhala’s picture

msankhala commented
Status: Needs review » Reviewed & tested by the community

Nice work @deepanker_bhalla and @dhirendra.mishra. I can confirm #6 fixes all the coding standard issue and concern raised in #4.

gangwarsurya’s picture

gangwarsurya commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new 2998722-coding-standard-7.patch991 bytes

Hi

Fixed the Coding standard issues.

msankhala’s picture

msankhala commented
Status: Needs review » Reviewed & tested by the community

@gangwarsurya Always double check the patch before uploading. This issue is for bootstrap_layouts module and you are uploading patch of contentimport module on this issue. This issue was already in RTBC state and you are putting back into Needs Review state with a wrong patch.

markhalliwell’s picture

markhalliwell
Primary language English
commented
Status: Reviewed & tested by the community » Closed (won't fix)

I would like to preface this by saying thank you for filing this issue and providing patches. What I am about to say is in no way directed to anyone specifically, but moreover the topic at large.

---

Automated tool reports aren't real issues, they're nitpicking. Please stop creating them. Coding standards change and evolve (some are even antiquated) and they'll be updated and "fixed" over time while the code is worked on. I'm closing this issue; please do not reopen.