I think it would be best if the code snippets would exactly match those in Google's documentation at https://developers.google.com/tag-manager/quickstart. Just to avoid questions like: "Oh, they look different! Is the module outdated?" :)
On the other hand I don't see the need for the compact setting.

CommentFileSizeAuthor
#9 google_tag-adjust-snippets-2998698.patch7.73 KBdamian.skiba
#2 google_tag-adjust-snippets-2998698-1.patch6.38 KBmfernea

Comments

mfernea created an issue. See original summary.

mfernea’s picture

mfernea commented
Status: Active » Needs review
StatusFileSize
new google_tag-adjust-snippets-2998698-1.patch6.38 KB

Here is the patch.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Parent issue: » #2878894: Add aria-hidden state to GTM noscript snippet

This is undoing some of the changes made in #2878894: Add aria-hidden state to GTM noscript snippet. The reasons for those changes should be taken into consideration here.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented

This is partially accomplished in #3009268: Remove iframe content and @title.

  • solotandem committed 9c749ae on 8.x-1.x 
    Issue #2998698 by mfernea, solotandem: Restore style attribute on...
solotandem’s picture

solotandem commented

With the commit in #5, what does not match exactly (other than the aria-hidden attribute on the noscript tag)?

shamsher_alam’s picture

shamsher_alam commented
Status: Needs review » Needs work

Patch is getting failed with the latest dev release of google_tag. Please update patch if required to fix.

solotandem’s picture

solotandem commented

Did you look at the html output from latest dev release? Also, see my question in #5.

damian.skiba’s picture

damian.skiba commented
StatusFileSize
new google_tag-adjust-snippets-2998698.patch7.73 KB

This is patch for 8.12 version.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Status: Needs work » Needs review
solotandem’s picture

solotandem commented
Status: Needs review » Fixed

Changing status for lack of follow-up, in particular to the question in #5.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.