Closed (fixed)
Project:
Feedback
Version:
5.x-2.0
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
25 Aug 2008 at 20:04 UTC
Updated:
17 Dec 2008 at 23:21 UTC
Jump to comment: Most recent file
Even when number of feedback entries in a fieldset is more than 50 there is no pager generated.
This is so because the pager code currently looks like
$item['messages'] = array(
'#value' => theme('table', $form['#feedback_header'], $rows) . theme('pager', array(), 50, $status),
'#weight' => -1,
);
However, $status is nowhere in scope in theme_feedback_admin_view_form() but we need some value in its place since we have multiple pagers on the same page.
Changing the code to something like
$queue_status = explode('-',$element);
$item['messages'] = array(
'#value' => theme('table', $form['#feedback_header'], $rows) . theme('pager', array(), 50, $queue_status[2]),
'#weight' => -1,
);
works. But that does not look very elegant to me. Neither am I able to find a better solution. Setting the issue to PCNW
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | feedback-DRUPAL-5--2.pager_.patch | 4.69 KB | sun |
| #2 | feedback-DRUPAL-5--2.patch | 4.67 KB | sun |
Comments
Comment #1
sunThat's true. If your solution works for both tables/pagers, then I'd definitely be happy to commit a patch that fixes the bug this way. There is no elegant solution for multiple pagers on one page in Drupal core (reminds me of pushing smk-ka to submit a patch for D7).
Comment #2
sunI think (and hope) this should do the trick. Please test.
Comment #3
sunCommitted attached patch to all branches.