Even when number of feedback entries in a fieldset is more than 50 there is no pager generated.
This is so because the pager code currently looks like

    $item['messages'] = array(
      '#value' => theme('table', $form['#feedback_header'], $rows) . theme('pager', array(), 50, $status),
      '#weight' => -1,
    );

However, $status is nowhere in scope in theme_feedback_admin_view_form() but we need some value in its place since we have multiple pagers on the same page.

Changing the code to something like

    $queue_status = explode('-',$element);
    $item['messages'] = array(
      '#value' => theme('table', $form['#feedback_header'], $rows) . theme('pager', array(), 50, $queue_status[2]),
      '#weight' => -1,
    );

works. But that does not look very elegant to me. Neither am I able to find a better solution. Setting the issue to PCNW

Comments

sun’s picture

That's true. If your solution works for both tables/pagers, then I'd definitely be happy to commit a patch that fixes the bug this way. There is no elegant solution for multiple pagers on one page in Drupal core (reminds me of pushing smk-ka to submit a patch for D7).

sun’s picture

Status: Needs work » Needs review
StatusFileSize
new4.67 KB

I think (and hope) this should do the trick. Please test.

sun’s picture

Status: Needs review » Fixed
StatusFileSize
new4.69 KB

Committed attached patch to all branches.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.