According to Drupal standards, modules should include dependencies in the .info.yml file.
Dependencies should be namespaced in the format {project}:{module}, where {project} is the project name as it appears in the Drupal.org URL (e.g. drupal.org/project/views) and {module} is the module's machine name.

https://www.drupal.org/docs/8/creating-custom-modules/let-drupal-8-know-...

Patch to follow...

CommentFileSizeAuthor
#4 guardr_core-update-format-dependencies-2998178-4.patch1005 bytesjoestewart
#2 guardr_core-update-format-dependencies-2998178-2.patch918 bytesjqtnguyen

Comments

JQTNguyen created an issue. See original summary.

jqtnguyen’s picture

jqtnguyen commented
Assigned: jqtnguyen » Unassigned
Status: Active » Needs review
StatusFileSize
new guardr_core-update-format-dependencies-2998178-2.patch918 bytes

Uploading patch for issue.

volkswagenchick’s picture

volkswagenchick
she/her
Primary language English
Location San Francisco Bay Area
commented
Status: Needs review » Reviewed & tested by the community

Code looks good. Dependency namespacing has been addressed. Patch applied via simplytest.me. Marking RTBC

joestewart’s picture

joestewart commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new guardr_core-update-format-dependencies-2998178-4.patch1005 bytes

Rerolled with three additional dependencies from Guardr.

hacked
mass_pwreset
security_review

References:
#3008977-6: Remove contrib dependencies from composer.json, let guardr_core manage them
#3008975-5: Add a composer.json for all of the dependencies
https://www.drupal.org/docs/8/creating-custom-modules/let-drupal-8-know-...

  • shrop committed ba1761c on 8.x-1.x authored by joestewart 
    Issue #2998178 by JQTNguyen, joestewart: Update Format of Dependencies...
shrop’s picture

shrop commented
Status: Needs review » Fixed

Thanks all! This has been merged.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.